All of lore.kernel.org
 help / color / mirror / Atom feed
From: Martijn Coenen <maco@android.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Ming Lei <ming.lei@redhat.com>, Jens Axboe <axboe@kernel.dk>,
	Bart Van Assche <bvanassche@acm.org>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	linux-block <linux-block@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	kernel-team@android.com
Subject: Re: [PATCH] loop: Add LOOP_SET_FD_WITH_OFFSET ioctl.
Date: Tue, 31 Mar 2020 13:25:41 +0200	[thread overview]
Message-ID: <CAB0TPYEwOd-jYJTkq1DYp=c7uXMKvpSpgpcpZGMwW2QsYkOtSw@mail.gmail.com> (raw)
In-Reply-To: <20200331074828.GA24372@lst.de>

On Tue, Mar 31, 2020 at 9:48 AM Christoph Hellwig <hch@lst.de> wrote:
> I think the full blown set fd an status would seem a lot more useful,
> or even better a LOOP_CTL_ADD variant that sets up everything important
> on the character device so that we avoid the half set up block devices
> entirely.

Thanks for the feedback, I will work on that then. I think I could do
both - LOOP_SET_FD_AND_STATUS and a new variant of LOOP_CTL_ADD that
calls it - the former could still be useful if the kernel pre-created
a large amount of loop devices.

Martijn

  reply	other threads:[~2020-03-31 11:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-29 14:04 [PATCH] loop: Add LOOP_SET_FD_WITH_OFFSET ioctl Martijn Coenen
2020-03-29 16:48 ` Chaitanya Kulkarni
2020-03-29 20:19 ` Bart Van Assche
2020-03-30  1:00 ` Ming Lei
2020-03-30  8:06   ` Martijn Coenen
2020-03-31  7:48     ` Christoph Hellwig
2020-03-31 11:25       ` Martijn Coenen [this message]
2020-03-31 11:40 Martijn Coenen
2020-03-31 11:42 ` Martijn Coenen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAB0TPYEwOd-jYJTkq1DYp=c7uXMKvpSpgpcpZGMwW2QsYkOtSw@mail.gmail.com' \
    --to=maco@android.com \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=hch@lst.de \
    --cc=kernel-team@android.com \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.