From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Kiran K <kiran.k@intel.com>
Cc: "linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
Chethan T N <chethan.tumkur.narayan@intel.com>,
Luiz Augusto Von Dentz <luiz.von.dentz@intel.com>
Subject: Re: [PATCH v4 06/14] Bluetooth: Remove unused member in struct hci_vnd_codec_v2
Date: Tue, 23 Nov 2021 15:52:31 -0800 [thread overview]
Message-ID: <CABBYNZ+9k60YTUsg1F_k2UgVz=9YixoQS5nwBrdJRjL+HOkPig@mail.gmail.com> (raw)
In-Reply-To: <20211119082027.12809-6-kiran.k@intel.com>
Hi Kiran,
On Fri, Nov 19, 2021 at 12:16 AM Kiran K <kiran.k@intel.com> wrote:
>
> Remove unused "u8 id" member in struct hci_vnd_codec_v2. Vendor codec
> is identifiable by Company Id and Vendor Id fields.
>
> Signed-off-by: Kiran K <kiran.k@intel.com>
> Reviewed-by: Chethan T N <chethan.tumkur.narayan@intel.com>
> Reviewed-by: Srivatsa Ravishankar <ravishankar.srivatsa@intel.com>
> ---
> include/net/bluetooth/hci.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h
> index e52fd2f1e046..54fae19f3758 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -1395,7 +1395,6 @@ struct hci_std_codecs_v2 {
> } __packed;
>
> struct hci_vnd_codec_v2 {
> - __u8 id;
> __le16 cid;
> __le16 vid;
> __u8 transport;
> --
> 2.17.1
Not following this change, afaik LC3 for example should be id 0x06
cid/vid 0x0000 as that is not a vendor, or this is never used for
codecs defined in the spec?
--
Luiz Augusto von Dentz
next prev parent reply other threads:[~2021-11-23 23:52 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-19 8:20 [PATCH v4 01/14] Bluetooth: Refactor code to read supported codecs in getsockopt Kiran K
2021-11-19 8:20 ` [PATCH v4 02/14] Bluetooth: Support reading of codecs supported over l2cap socket Kiran K
2021-11-19 8:20 ` [PATCH v4 03/14] Bluetooth: btintel: cache offload use case data Kiran K
2021-11-19 8:20 ` [PATCH v4 04/14] Bluetooth: Pass transport type in get_data_path_id Kiran K
2021-11-23 23:43 ` Luiz Augusto von Dentz
2021-11-19 8:20 ` [PATCH v4 05/14] Bluetooth: btintel: Add support to fetch data path id for a2dp offload Kiran K
2021-11-23 23:49 ` Luiz Augusto von Dentz
2021-11-19 8:20 ` [PATCH v4 06/14] Bluetooth: Remove unused member in struct hci_vnd_codec_v2 Kiran K
2021-11-23 23:52 ` Luiz Augusto von Dentz [this message]
2021-11-19 8:20 ` [PATCH v4 07/14] Bluetooth: Read Output codec capabilities Kiran K
2021-11-19 8:20 ` [PATCH v4 08/14] Bluetooth: Implement MSFT avdtp open command Kiran K
2021-11-24 1:26 ` Luiz Augusto von Dentz
2021-11-19 8:20 ` [PATCH v4 09/14] Bluetooth: Handle MSFT avdtp open event Kiran K
2021-11-19 8:20 ` [PATCH v4 10/14] " Kiran K
2021-11-19 8:20 ` [PATCH v4 11/14] Bluetooth: Implment MSFT avdtp start command Kiran K
2021-11-19 8:20 ` [PATCH v4 12/14] Bluetooth: Implment MSFT avdtp suspend command Kiran K
2021-11-19 8:20 ` [PATCH v4 13/14] Bluetooth: Implment MSFT avdtp close command Kiran K
2021-11-19 8:20 ` [PATCH v4 14/14] Bluetooth: Add MSFT a2dp offload codec under experimental flag Kiran K
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CABBYNZ+9k60YTUsg1F_k2UgVz=9YixoQS5nwBrdJRjL+HOkPig@mail.gmail.com' \
--to=luiz.dentz@gmail.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=kiran.k@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.von.dentz@intel.com \
--cc=ravishankar.srivatsa@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.