Re: [EXT] Re: [PATCH BlueZ v1 1/1] LE Create Connection command timeout increased to 20 secs from 4 secs

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Mahesh Talewad <mahesh.talewad@nxp.com>
Cc: "linux-bluetooth@vger.kernel.org"
	<linux-bluetooth@vger.kernel.org>,
	 Devyani Godbole <devyani.godbole@nxp.com>,
	Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>
Subject: Re: [EXT] Re: [PATCH BlueZ v1 1/1] LE Create Connection command timeout increased to 20 secs from 4 secs
Date: Tue, 30 Apr 2024 09:31:57 -0400	[thread overview]
Message-ID: <CABBYNZJ3Bcakaw12UCVRQRzM6GaPpgz7UeS3BhYdSw8bdvqdag@mail.gmail.com> (raw)
In-Reply-To: <AS5PR04MB97540A3B63FC307F4B64F2BB891A2@AS5PR04MB9754.eurprd04.prod.outlook.com>

Hi Mahesh,

On Tue, Apr 30, 2024 at 8:23 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote:
>
> Hi Luiz,
>
> Thank you. This patch is working. le connection timeout successfully changed to 20secs.

Please send as a proper patch then.

> Thanks and regards,
> Mahesh Vithal Talewad
>
> -----Original Message-----
> From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
> Sent: Thursday, April 25, 2024 1:02 AM
> To: Mahesh Talewad <mahesh.talewad@nxp.com>
> Cc: linux-bluetooth@vger.kernel.org; Devyani Godbole <devyani.godbole@nxp.com>; Sarveshwar Bajaj <sarveshwar.bajaj@nxp.com>
> Subject: Re: [EXT] Re: [PATCH BlueZ v1 1/1] LE Create Connection command timeout increased to 20 secs from 4 secs
>
> Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button
>
>
> Hi Mahesh,
>
> On Wed, Apr 24, 2024 at 9:49 AM Mahesh Talewad <mahesh.talewad@nxp.com> wrote:
> >
> > Hi Luiz,
> >
> > We tried with - 6093f28402aa6342890fc3adb6be355f804b719d - with this as well issue is observed.
>
> The lets do something like:
>
> diff --git a/include/net/bluetooth/hci.h b/include/net/bluetooth/hci.h index 5c12761cbc0e..fbf0a6263dae 100644
> --- a/include/net/bluetooth/hci.h
> +++ b/include/net/bluetooth/hci.h
> @@ -456,7 +456,6 @@ enum {
>  #define HCI_AUTO_OFF_TIMEOUT   msecs_to_jiffies(2000)  /* 2 seconds */
>  #define HCI_ACL_CONN_TIMEOUT   msecs_to_jiffies(20000) /* 20 seconds */
>  #define HCI_LE_CONN_TIMEOUT    msecs_to_jiffies(20000) /* 20 seconds */
> -#define HCI_LE_AUTOCONN_TIMEOUT        msecs_to_jiffies(4000)  /* 4 seconds */
>
>  /* HCI data types */
>  #define HCI_COMMAND_PKT                0x01
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c index 99b4e68075f4..651e5105fdd5 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -2556,7 +2556,7 @@ struct hci_dev *hci_alloc_dev_priv(int sizeof_priv)
>         hdev->le_rx_def_phys = HCI_LE_SET_PHY_1M;
>         hdev->le_num_of_adv_sets = HCI_MAX_ADV_INSTANCES;
>         hdev->def_multi_adv_rotation_duration = HCI_DEFAULT_ADV_DURATION;
> -       hdev->def_le_autoconnect_timeout = HCI_LE_AUTOCONN_TIMEOUT;
> +       hdev->def_le_autoconnect_timeout = HCI_LE_CONN_TIMEOUT;
>         hdev->min_le_tx_power = HCI_TX_POWER_INVALID;
>         hdev->max_le_tx_power = HCI_TX_POWER_INVALID;

-- 
Luiz Augusto von Dentz