Re: [BlueZ,1/3] avdtp: Fix setting disconnect timer when there is no local endpoints

From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: Miao-chen Chou <mcchou@chromium.org>
Cc: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Subject: Re: [BlueZ,1/3] avdtp: Fix setting disconnect timer when there is no local endpoints
Date: Wed, 17 Feb 2021 17:28:03 -0800	[thread overview]
Message-ID: <CABBYNZKMd4_rX5LWTBZPGp6a=zWz+QtQTPkfRu5ZejR_cRn7jw@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZKBW+Faraq_Ljj7_WT9HdEZgL19g2-r59T66wxmPt8kEA@mail.gmail.com>

Hi,

On Wed, Feb 17, 2021 at 1:24 PM Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
>
> Hi Miao,
>
> On Wed, Feb 17, 2021 at 12:37 PM Miao-chen Chou <mcchou@chromium.org> wrote:
> >
> > Hi Luiz,
> >
> > I was testing before seeing your email. Please take a look at my
> > comment on the last commit of the series.
> > Although this commit doesn't affect the symptom we observed (it was
> > IDLE state which triggers the disconnection of IO), the change makes
> > sense.
>
> Yep, this doesn't actually make any difference on the matter of
> freeing avdtp session when the adapter is removed but as you said it
> makes sense on it own given that local endpoints can be unregistered.
>
> > On Wed, Feb 17, 2021 at 11:45 AM Luiz Augusto von Dentz
> > <luiz.dentz@gmail.com> wrote:
> > >
> > > Hi Miao,
> > >
> > > On Tue, Feb 16, 2021 at 3:57 PM <bluez.test.bot@gmail.com> wrote:
> > > >
> > > > This is automated email and please do not reply to this email!
> > > >
> > > > Dear submitter,
> > > >
> > > > Thank you for submitting the patches to the linux bluetooth mailing list.
> > > > This is a CI test results with your patch series:
> > > > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=434305
> > > >
> > > > ---Test result---
> > > >
> > > > ##############################
> > > > Test: CheckPatch - PASS
> > > >
> > > > ##############################
> > > > Test: CheckGitLint - PASS
> > > >
> > > > ##############################
> > > > Test: CheckBuild - PASS
> > > >
> > > > ##############################
> > > > Test: MakeCheck - PASS
> > > >
> > > >
> > > >
> > > > ---
> > > > Regards,
> > > > Linux Bluetooth
> > >
> > > Can you give this set a try with the use case you had? I tested with
> > > unplugged use case and it now seems to trigger session_cb immediately
> > > so it should work for your case as well.
> > >
> > > --
> > > Luiz Augusto von Dentz
> > Thanks,
> > Miao
>
>
>
> --
> Luiz Augusto von Dentz

Pushed.

-- 
Luiz Augusto von Dentz