Re: [PATCH 1/4] show-branch: show reflog message

From: Elijah Newren <newren@gmail.com>
To: Bagas Sanjaya <bagasdotme@gmail.com>
Cc: Han-Wen Nienhuys via GitGitGadget <gitgitgadget@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	Han-Wen Nienhuys <hanwenn@gmail.com>,
	Han-Wen Nienhuys <hanwen@google.com>
Subject: Re: [PATCH 1/4] show-branch: show reflog message
Date: Tue, 23 Nov 2021 00:03:44 -0800	[thread overview]
Message-ID: <CABPp-BF+C1_XS+9FKwhwur4s5j0dUqs1VP8PDdZzw-edbfhRjQ@mail.gmail.com> (raw)
In-Reply-To: <3ff61d01-ddd1-6b67-d8cb-4bd22736738e@gmail.com>

On Mon, Nov 22, 2021 at 11:44 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On 22/11/21 21.20, Han-Wen Nienhuys via GitGitGadget wrote:
> > From: Han-Wen Nienhuys <hanwen@google.com>
> >
> > Before, --reflog option would look for '\t' in the reflog message. As refs.c
> > already parses the reflog line, the '\t' was never found, and show-branch
> > --reflog would always say "(none)" as reflog message
> >
> > Add test.
> >
>
> Add what the test?
>
> > +# arbitrary reference time: 2009-08-30 19:20:00
> > +GIT_TEST_DATE_NOW=1251660000; export GIT_TEST_DATE_NOW
> > +
>
> Why don't you use oneliner `export GIT_TEST_DATE_NOW=1251660000`?

t/check-non-portable-shell.pl will flag this construct and throw an
error if you put that in your test script.