From: Elijah Newren <newren@gmail.com>
To: Derrick Stolee via GitGitGadget <gitgitgadget@gmail.com>
Cc: "Git Mailing List" <git@vger.kernel.org>,
"SZEDER Gábor" <szeder.dev@gmail.com>,
jon@jonsimons.org, "Derrick Stolee" <dstolee@microsoft.com>,
"Junio C Hamano" <gitster@pobox.com>
Subject: Re: [PATCH 0/1] sparse-checkout: list directories in cone mode
Date: Fri, 27 Dec 2019 13:47:49 -0800 [thread overview]
Message-ID: <CABPp-BFAcWVrtoYMHghkk4AOEYaUWq0cD3xjtUwMPc2bfvrWSw@mail.gmail.com> (raw)
In-Reply-To: <pull.500.git.1577393347.gitgitgadget@gmail.com>
On Thu, Dec 26, 2019 at 12:49 PM Derrick Stolee via GitGitGadget
<gitgitgadget@gmail.com> wrote:
>
> When in cone mode, "git sparse-checkout set" takes a list of folders and
> constructs an ordered list of patterns for the sparse-checkout file. The
> "git sparse-checkout list" subcommand outputs the contents of the
> sparse-checkout file in a very basic way.
>
> This patch changes the behavior of "git sparse-checkout list" when
> core.sparseCheckoutCone=true. It will output the folders that were used in
> "git sparse-checkout set" to create the patterns, instead of the patterns
> themselves.
>
> I believe this was requested in the initial review, but I cannot find that
> message now.
Yeah, I think I mentioned it, but couldn't remember for sure. Just
did a little digging and found
https://lore.kernel.org/git/CABPp-BH13XbNR3MQKE7cHO5e=pMY7kLtGhkX1SQg_o9it=uUug@mail.gmail.com/:
"Should the list mode in cone mode be modified to just show the
directories the user added? It seems a little weird to show the
internal details of the implementation (all the parent directories and
negated entries and whatnot). That's also not in a form that users
can pass along to future `sparse-checkout add` invocations."
Though I then went into other tangents, which may have been what
caused it to be forgotten or overlooked.
> I was going to include this as part of a longer follow-up series, but I
> think this may be worth considering for the 2.25.0 release. Hence, it is
> included by itself.
Yeah, I think this is a good and small fixup to a new feature in
2.25.0, so it'd be nice if it could be included. Not sure if it's too
late given that we're at -rc0, but here's a thumbs up from me if it
makes any difference.
prev parent reply other threads:[~2019-12-27 21:47 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-26 20:49 [PATCH 0/1] sparse-checkout: list directories in cone mode Derrick Stolee via GitGitGadget
2019-12-26 20:49 ` [PATCH 1/1] sparse-checkout: list folders " Derrick Stolee via GitGitGadget
2019-12-26 21:17 ` Junio C Hamano
2019-12-27 14:05 ` Derrick Stolee
2019-12-27 15:52 ` Elijah Newren
2019-12-27 18:47 ` [PATCH v2 0/2] sparse-checkout: list directories " Derrick Stolee via GitGitGadget
2019-12-27 18:47 ` [PATCH v2 1/2] sparse-checkout: list folders " Derrick Stolee via GitGitGadget
2019-12-27 21:37 ` Elijah Newren
2019-12-27 18:47 ` [PATCH v2 2/2] sparse-checkout: document interactions with submodules Derrick Stolee via GitGitGadget
2019-12-27 20:20 ` Eric Sunshine
2019-12-30 13:11 ` Derrick Stolee
2019-12-27 21:46 ` Elijah Newren
2019-12-27 22:33 ` Junio C Hamano
2019-12-30 15:33 ` [PATCH v3 0/2] sparse-checkout: list directories in cone mode Derrick Stolee via GitGitGadget
2019-12-30 15:33 ` [PATCH v3 1/2] " Derrick Stolee via GitGitGadget
2019-12-30 15:33 ` [PATCH v3 2/2] sparse-checkout: document interactions with submodules Derrick Stolee via GitGitGadget
2019-12-30 17:18 ` [PATCH v3 0/2] sparse-checkout: list directories in cone mode Elijah Newren
2019-12-27 21:47 ` Elijah Newren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CABPp-BFAcWVrtoYMHghkk4AOEYaUWq0cD3xjtUwMPc2bfvrWSw@mail.gmail.com \
--to=newren@gmail.com \
--cc=dstolee@microsoft.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=jon@jonsimons.org \
--cc=szeder.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.