Re: [PATCH 15/19] drm/i915: don't enable VDD just to enable the panel

From: Rodrigo Vivi <rodrigo.vivi@gmail.com>
To: Paulo Zanoni <przanoni@gmail.com>
Cc: intel-gfx <intel-gfx@lists.freedesktop.org>,
	Paulo Zanoni <paulo.r.zanoni@intel.com>
Subject: Re: [PATCH 15/19] drm/i915: don't enable VDD just to enable the panel
Date: Fri, 29 Nov 2013 12:40:02 -0200	[thread overview]
Message-ID: <CABVU7+vbnuW5R_nWi31r2N3uYngMfs_rRqM8WnEzcDHgwiUy7Q@mail.gmail.com> (raw)
In-Reply-To: <1385048853-1579-16-git-send-email-przanoni@gmail.com>

I'm just not sure if it won't regress in any other platform... Just
wondering why it was added in this way.... But..

makes sense so feel free to use:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@gmail.com>

On Thu, Nov 21, 2013 at 1:47 PM, Paulo Zanoni <przanoni@gmail.com> wrote:
> From: Paulo Zanoni <paulo.r.zanoni@intel.com>
>
> We just don't need this. This saves 250ms from every modeset on my
> machine.
>
> Signed-off-by: Paulo Zanoni <paulo.r.zanoni@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_ddi.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 731a919..e868f5f 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -1122,9 +1122,7 @@ static void intel_ddi_pre_enable(struct intel_encoder *intel_encoder)
>
>         if (type == INTEL_OUTPUT_EDP) {
>                 struct intel_dp *intel_dp = enc_to_intel_dp(encoder);
> -               ironlake_edp_panel_vdd_on(intel_dp);
>                 ironlake_edp_panel_on(intel_dp);
> -               ironlake_edp_panel_vdd_off(intel_dp, true);
>         }
>
>         WARN_ON(intel_crtc->ddi_pll_sel == PORT_CLK_SEL_NONE);
> --
> 1.8.3.1
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Rodrigo Vivi
Blog: http://blog.vivi.eng.br