Re: [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree

From: Praveen Kumar <kpraveen.lkml@gmail.com>
To: xen-devel@lists.xen.org
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Andrew Cooper <andrew.cooper3@citrix.com>,
	Dario Faggioli <dario.faggioli@citrix.com>,
	ian.jackson@eu.citrix.com, tim@xen.org,
	Praveen Kumar <kpraveen.lkml@gmail.com>,
	Jan Beulich <jbeulich@suse.com>
Subject: Re: [PATCH v6 00/16] xen: common: rbtree: ported updates from Linux tree
Date: Tue, 5 Dec 2017 21:49:06 +0530	[thread overview]
Message-ID: <CABcWhv7wyaAbSguPwHYh1fxxpWVHAGge13vBnoBLBtGCHd7DZQ@mail.gmail.com> (raw)
In-Reply-To: <20171121152009.15591-1-kpraveen.lkml@gmail.com>

Hi All,

Can you please provide your comments over the changes shared. Thanks in advance.

Regards,

~Praveen.

On Tue, Nov 21, 2017 at 8:49 PM, Praveen Kumar <kpraveen.lkml@gmail.com> wrote:
> Hi All,
>
> The patch imports the changes and updates of the rbtree implementaiton
> from Linux tree. But since, the only current implementation is with tmem.c,
> which am not much aware off much and therefore, was unable to test the changes
> thoroughly. Having said that, I do have plans of adding futher code changes
> which will be using rb-tree more in credit2 scheduler and that will help in
> further testing the same.
>
> I have not imported augmented, rcu and patches which added new rbtree
> functionality, as there was no specific requirement for current planned
> implementation.
>
> Below are the categorized Linux commit versions which are not imported :
>
> Augmented rbtree :
> 14b94af0b251a2c80885b60538166fb7d04a642e
> 9d9e6f9703bbd642f3f2f807e6aaa642a4cbcec9
> 9c079add0d0f45220f4bb37febf0621137ec2d38
> 3cb7a56344ca45ee56d71c5f8fe9f922306bff1f
> f231aebfc4cae2f6ed27a46a31e2630909513d77
>
>
> Add postorder iteration functions:
> 9dee5c51516d2c3fff22633c1272c5652e68075a
>
> RCU related implementation :
> d72da4a4d973d8a0a0d3c97e7cdebf287fbe3a99
> c1adf20052d80f776849fa2c1acb472cdeb7786c
> ce093a04543c403d52c1a5788d8cb92e47453aba
>
> Please share your inputs. Thanks in advance.
>
> Regards,
>
> ~Praveen.
>
> Praveen Kumar (16):
>   rbtree: remove redundant if()-condition in rb_erase()
>   rbtree: empty nodes have no color
>   rbtree: move some implementation details from rbtree.h to rbtree.c
>   rbtree: break out of rb_insert_color loop after tree rotation
>   rbtree: adjust root color in rb_insert_color() only when necessary
>   rbtree: low level optimizations in rb_insert_color()
>   rbtree: adjust node color in __rb_erase_color() only when necessary
>   rbtree: optimize case selection logic in __rb_erase_color()
>   rbtree: low level optimizations in __rb_erase_color()
>   rbtree: coding style adjustments
>   rbtree: optimize fetching of sibling node
>   rbtree: add __rb_change_child() helper function
>   rbtree: place easiest case first in rb_erase()
>   rbtree: handle 1-child recoloring in rb_erase() instead of
>     rb_erase_color()
>   rbtree: low level optimizations in rb_erase()
>   rbtree: fix typo in comment of rb_insert_color
>
>  xen/common/rbtree.c      | 646 ++++++++++++++++++++++++++++++-----------------
>  xen/include/xen/rbtree.h |  38 +--
>  2 files changed, 428 insertions(+), 256 deletions(-)
>
> ---
> Updated set of changes catering the comments provided.
> 2.13.1
>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel