Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool

From: Tamas K Lengyel <tamas.k.lengyel@gmail.com>
To: "Michał Leszczyński" <michal.leszczynski@cert.pl>
Cc: Xen-devel <xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>,
	Tamas K Lengyel <tamas.lengyel@intel.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	"Kang, Luwei" <luwei.kang@intel.com>
Subject: Re: [PATCH v3 7/7] tools/proctrace: add proctrace tool
Date: Tue, 23 Jun 2020 03:35:30 -0600	[thread overview]
Message-ID: <CABfawh=uHn1dF5jXc1FpymOLESEJ7tfpxr6SZBrHJMuqeMwsqg@mail.gmail.com> (raw)
In-Reply-To: <1786138246.11444015.1592849576272.JavaMail.zimbra@cert.pl>

> +    rc = xenforeignmemory_unmap_resource(fmem, fres);
> +
> +    if (rc) {
> +        fprintf(stderr, "Failed to unmap resource\n");
> +        return 1;
> +    }
> +
> +    rc = xc_vmtrace_pt_disable(xc, domid, vcpu_id);
> +
> +    if (rc) {
> +        fprintf(stderr, "Failed to call xc_vmtrace_pt_disable\n");
> +        return 1;
> +    }

Looks like you are missing an xc_interface_close here.

> +
> +    return 0;
> +}
> +
> +/*
> + * Local variables:
> + * mode: C
> + * c-file-style: "BSD"
> + * c-basic-offset: 4
> + * tab-width: 4
> + * indent-tabs-mode: nil
> + * End:
> + */
> --
> 2.20.1
>
>