From: Paul Durrant <pdurrant@gmail.com>
To: Wei Liu <wl@xen.org>
Cc: "Wei Liu" <liuwe@microsoft.com>,
"Andrew Cooper" <andrew.cooper3@citrix.com>,
"Michael Kelley" <mikelley@microsoft.com>,
"Jan Beulich" <jbeulich@suse.com>,
"Xen Development List" <xen-devel@lists.xenproject.org>,
"Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: [Xen-devel] [PATCH v2] x86/hyperv: change hv_tlb_flush_ex to fix clang build
Date: Mon, 23 Dec 2019 14:20:25 +0000 [thread overview]
Message-ID: <CACCGGhC=jksVoR8cy5XwYx=uSEq6Me4pz_JWaM-Ze5XaFhFidg@mail.gmail.com> (raw)
In-Reply-To: <20191223110330.26883-1-liuwe@microsoft.com>
On Mon, 23 Dec 2019 at 11:03, Wei Liu <wl@xen.org> wrote:
>
> Clang complains:
>
> In file included from synic.c:15:
> /builds/xen-project/xen/xen/include/asm/guest/hyperv-tlfs.h:900:18: error: field 'hv_vp_set' with variable sized type 'struct hv_vpset' not at the end of a struct or class is a GNU extension [-Werror,-Wgnu-variable-sized-type-not-at-end]
> struct hv_vpset hv_vp_set;
> ^
> 1 error generated.
> /builds/xen-project/xen/xen/Rules.mk:198: recipe for target 'synic.o' failed
> make[6]: *** [synic.o] Error 1
>
> Comment out the last variable size array from hv_tlb_flush_ex to fix
> clang builds.
>
> Signed-off-by: Wei Liu <liuwe@microsoft.com>
> Cc: Paul Durrant <paul@xen.org>
Reviewed-by: Paul Durrant <paul@xen.org>
> ---
> xen/include/asm-x86/guest/hyperv-tlfs.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/xen/include/asm-x86/guest/hyperv-tlfs.h b/xen/include/asm-x86/guest/hyperv-tlfs.h
> index fe9fb232d0..5b43f99de8 100644
> --- a/xen/include/asm-x86/guest/hyperv-tlfs.h
> +++ b/xen/include/asm-x86/guest/hyperv-tlfs.h
> @@ -908,12 +908,12 @@ struct hv_tlb_flush {
> u64 gva_list[];
> } __packed;
>
> -/* HvFlushVirtualAddressSpaceEx, HvFlushVirtualAddressListEx hypercalls */
> +/* HvFlushVirtualAddressSpaceEx hypercall */
> struct hv_tlb_flush_ex {
> u64 address_space;
> u64 flags;
> struct hv_vpset hv_vp_set;
> - u64 gva_list[];
> + /* u64 gva_list[]; */
> } __packed;
>
> struct hv_partition_assist_pg {
> --
> 2.20.1
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel
prev parent reply other threads:[~2019-12-23 14:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 11:03 [Xen-devel] [PATCH v2] x86/hyperv: change hv_tlb_flush_ex to fix clang build Wei Liu
2019-12-23 11:05 ` Jan Beulich
2019-12-23 14:20 ` Paul Durrant [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACCGGhC=jksVoR8cy5XwYx=uSEq6Me4pz_JWaM-Ze5XaFhFidg@mail.gmail.com' \
--to=pdurrant@gmail.com \
--cc=andrew.cooper3@citrix.com \
--cc=jbeulich@suse.com \
--cc=liuwe@microsoft.com \
--cc=mikelley@microsoft.com \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.