From: Joel Stanley <joel@jms.id.au>
To: "Oliver O'Halloran" <oohall@gmail.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/6] powerpc/powernv: Staticify functions without prototypes
Date: Tue, 4 Aug 2020 02:17:49 +0000 [thread overview]
Message-ID: <CACPK8XcbsaZ=7x07CjiCDNfMeiA2AVi6k_WWQnS50eERt6QAow@mail.gmail.com> (raw)
In-Reply-To: <20200804005410.146094-4-oohall@gmail.com>
On Tue, 4 Aug 2020 at 01:01, Oliver O'Halloran <oohall@gmail.com> wrote:
>
> There's a few scattered in the powernv platform.
>
> Signed-off-by: Oliver O'Halloran <oohall@gmail.com>
> +++ b/arch/powerpc/platforms/powernv/eeh-powernv.c
> @@ -38,7 +38,7 @@
>
> static int eeh_event_irq = -EINVAL;
>
> -void pnv_pcibios_bus_add_device(struct pci_dev *pdev)
> +static void pnv_pcibios_bus_add_device(struct pci_dev *pdev)
> {
> dev_dbg(&pdev->dev, "EEH: Setting up device\n");
> eeh_probe_device(pdev);
This one could even be deleted as eeh_probe_device has it's own dev_dbg.
Reviewed-by: Joel Stanley <joel@jms.id.au>
next prev parent reply other threads:[~2020-08-04 2:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-04 0:54 Clean up W=1 for the powernv platform Oliver O'Halloran
2020-08-04 0:54 ` [PATCH 1/6] powerpc/powernv/smp: Fix spurious DBG() warning Oliver O'Halloran
2020-08-04 2:07 ` Joel Stanley
2020-08-04 6:58 ` Oliver O'Halloran
2020-08-04 12:05 ` Michael Ellerman
2020-09-09 13:37 ` Michael Ellerman
2020-08-04 0:54 ` [PATCH 2/6] powerpc/powernv: Include asm/powernv.h from the local powernv.h Oliver O'Halloran
2020-08-04 0:54 ` [PATCH 3/6] powerpc/powernv: Staticify functions without prototypes Oliver O'Halloran
2020-08-04 2:17 ` Joel Stanley [this message]
2020-08-04 0:54 ` [PATCH 4/6] powerpc/powernv: Fix spurious kerneldoc warnings in opal-prd.c Oliver O'Halloran
2020-08-04 2:18 ` Joel Stanley
2020-08-04 0:54 ` [PATCH 5/6] powerpc/powernv/pci: Drop unused parent variable Oliver O'Halloran
2020-08-04 2:19 ` Joel Stanley
2020-08-04 0:54 ` [PATCH 6/6] powerpc/nx: Don't pack struct coprocessor_request_block Oliver O'Halloran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACPK8XcbsaZ=7x07CjiCDNfMeiA2AVi6k_WWQnS50eERt6QAow@mail.gmail.com' \
--to=joel@jms.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=oohall@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.