Re: [PATCH v2 2/2] tests/acceptance: Test ast2600 machine

From: Joel Stanley <joel@jms.id.au>
To: Wainer dos Santos Moschetta <wainersm@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
	"Andrew Jeffery" <andrew@aj.id.au>,
	"QEMU Developers" <qemu-devel@nongnu.org>,
	qemu-arm <qemu-arm@nongnu.org>, "Cédric Le Goater" <clg@kaod.org>,
	"Cleber Rosa" <crosa@redhat.com>,
	"Philippe Mathieu-Daudé" <philmd@redhat.com>
Subject: Re: [PATCH v2 2/2] tests/acceptance: Test ast2600 machine
Date: Tue, 9 Mar 2021 06:19:31 +0000	[thread overview]
Message-ID: <CACPK8XfYVO2VBcvAhPXPx+MSe75Oi+YoJ-SCAGhUWDs1xh4RNQ@mail.gmail.com> (raw)
In-Reply-To: <5e6691b6-1cdc-8d66-25e7-4df1be63be46@redhat.com>

On Fri, 5 Mar 2021 at 20:46, Wainer dos Santos Moschetta
<wainersm@redhat.com> wrote:
>
> Hi,
>
> On 3/4/21 9:39 AM, Joel Stanley wrote:
> > This tests a Debian multi-soc arm32 Linux kernel on the AST2600 based
> > Tacoma BMC machine.
> >
> > There is no root file system so the test terminates when boot reaches
> > the stage where it attempts and fails to mount something.
> >
> > Signed-off-by: Joel Stanley <joel@jms.id.au>
> > ---
> > v2: Update expected strings so test passes
> > ---
> >   tests/acceptance/boot_linux_console.py | 26 ++++++++++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> >
> > diff --git a/tests/acceptance/boot_linux_console.py b/tests/acceptance/boot_linux_console.py
> > index 2f46a08fdc10..4f1df69bc75c 100644
> > --- a/tests/acceptance/boot_linux_console.py
> > +++ b/tests/acceptance/boot_linux_console.py
> > @@ -1094,6 +1094,32 @@ def do_test_arm_aspeed(self, image):
> >           # self.wait_for_console_pattern("login:")
> >           self.vm.shutdown()
> >
> > +    def test_arm_ast2600_debian(self):
> > +        """
> > +        :avocado: tags=arch:arm
> > +        :avocado: tags=machine:tacoma-bmc
> > +        """
> > +        deb_url = ('http://snapshot.debian.org/archive/debian/'
> > +                   '20210302T203551Z/'
> > +                   'pool/main/l/linux/'
> > +                   'linux-image-5.10.0-3-armmp_5.10.13-1_armhf.deb')
> > +        deb_hash = 'db40d32fe39255d05482bea48d72467b67d6225bb2a2a4d6f618cb8976f1e09e'
> > +        deb_path = self.fetch_asset(deb_url, asset_hash=deb_hash,
> > +                                    algorithm='sha256')
> > +        kernel_path = self.extract_from_deb(deb_path, '/boot/vmlinuz-5.10.0-3-armmp')
> > +        dtb_path = self.extract_from_deb(deb_path,
> > +                '/usr/lib/linux-image-5.10.0-3-armmp/aspeed-bmc-opp-tacoma.dtb')
> > +
> > +        self.vm.set_console()
> > +        self.vm.add_args('-kernel', kernel_path,
> > +                         '-dtb', dtb_path,
> > +                         '-net', 'nic')
> > +        self.vm.launch()
> > +        self.wait_for_console_pattern("Booting Linux on physical CPU 0xf00")
> > +        self.wait_for_console_pattern("SMP: Total of 2 processors activated")
>
> Above check isn't reliable. Here the VM started with smp 1, therefore
> the test failed as:

We should reliably pass that check once this fix has been merged:

 https://lore.kernel.org/qemu-devel/20210303010505.635621-1-joel@jms.id.au/T/

Having that line included is helpful, as it tests the smp boot stub
functionality in our emulated machine.

>
> FAIL: Failure message found in console: Kernel panic - not syncing
>
> > +        self.wait_for_console_pattern("No filesystem could mount root")
> > +        self.vm.shutdown()
>
> You don't need to shutdown the VM as the test's tearDown() does that for
> you.

Thanks, I'll send a v2 with those removed.

>
> Thanks!
>
> - Wainer
>
> > +
> >       def test_m68k_mcf5208evb(self):
> >           """
> >           :avocado: tags=arch:m68k
>