From: Linus Walleij <linus.walleij@linaro.org>
To: Baolin Wang <baolin.wang7@gmail.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
Orson Zhai <orsonzhai@gmail.com>,
Lyra Zhang <zhang.lyra@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "gpio: eic-sprd: Use devm_platform_ioremap_resource()"
Date: Thu, 2 Apr 2020 09:40:05 +0200 [thread overview]
Message-ID: <CACRpkdYYsPKFBKPVXHa-k5jmQ_8BPfpqmWAUNfSNzar+CedXmA@mail.gmail.com> (raw)
In-Reply-To: <8d3579f4b49bb675dc805035960f24852898be28.1585734060.git.baolin.wang7@gmail.com>
On Wed, Apr 1, 2020 at 11:59 AM Baolin Wang <baolin.wang7@gmail.com> wrote:
> This reverts commit 0f5cb8cc27a266c81e6523b436479802e9aafc9e.
>
> This commit will cause below warnings, since our EIC controller can support
> differnt banks on different Spreadtrum SoCs, and each bank has its own base
> address, we will get invalid resource warning if the bank number is less than
> SPRD_EIC_MAX_BANK on some Spreadtrum SoCs.
>
> So we should not use devm_platform_ioremap_resource() here to remove the
> warnings.
>
> [ 1.118508] sprd-eic 40210000.gpio: invalid resource
> [ 1.118535] sprd-eic 40210000.gpio: invalid resource
> [ 1.119034] sprd-eic 40210080.gpio: invalid resource
> [ 1.119055] sprd-eic 40210080.gpio: invalid resource
> [ 1.119462] sprd-eic 402100a0.gpio: invalid resource
> [ 1.119482] sprd-eic 402100a0.gpio: invalid resource
> [ 1.119893] sprd-eic 402100c0.gpio: invalid resource
> [ 1.119913] sprd-eic 402100c0.gpio: invalid resource
>
> Signed-off-by: Baolin Wang <baolin.wang7@gmail.com>
Patch applied.
Yours,
Linus Walleij
prev parent reply other threads:[~2020-04-02 7:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-01 9:59 [PATCH] Revert "gpio: eic-sprd: Use devm_platform_ioremap_resource()" Baolin Wang
2020-04-02 7:40 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdYYsPKFBKPVXHa-k5jmQ_8BPfpqmWAUNfSNzar+CedXmA@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=baolin.wang7@gmail.com \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.