Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors

From: Linus Walleij <linus.walleij@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Jingoo Han <jingoohan1@gmail.com>,
	Daniel Thompson <daniel.thompson@linaro.org>,
	Andrea Adami <andrea.adami@gmail.com>,
	"open list:DRM PANEL DRIVERS" <dri-devel@lists.freedesktop.org>,
	Robert Jarzmik <robert.jarzmik@free.fr>
Subject: Re: [PATCH] backlight: corgi: Convert to use GPIO descriptors
Date: Tue, 17 Dec 2019 16:19:13 +0100	[thread overview]
Message-ID: <CACRpkdZARO4wtDEapAKhKkVinrG-suXOCk2DR3xD9OwaUVXrAA@mail.gmail.com> (raw)
In-Reply-To: <20191216162729.GR2369@dell>

On Mon, Dec 16, 2019 at 5:27 PM Lee Jones <lee.jones@linaro.org> wrote:
> On Tue, 03 Dec 2019, Linus Walleij wrote:
>
> > The code in the Corgi backlight driver can be considerably
> > simplified by moving to GPIO descriptors and lookup tables
> > from the board files instead of passing GPIO numbers using
> > the old API.
> >
> > Make sure to encode inversion semantics for the Akita and
> > Spitz platforms inside the GPIO lookup table and drop the
> > custom inversion semantics from the driver.
> >
> > All in-tree users are converted in this patch.
> >
> > Cc: Andrea Adami <andrea.adami@gmail.com>
> > Cc: Robert Jarzmik <robert.jarzmik@free.fr>
> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
> > ---
> >  arch/arm/mach-pxa/corgi.c           | 12 ++++-
> >  arch/arm/mach-pxa/spitz.c           | 34 +++++++++++----
>
> Does this have an Arm Ack yet?

Yes Robert Jarzmik is the maintainer of arch/arm/mach-pxa,
or do you mean I should ask for the ARM SoC maintainers'
ACK explicitly (then I'd just resend, NP).

> >  drivers/video/backlight/corgi_lcd.c | 68 ++++++++---------------------
> >  include/linux/spi/corgi_lcd.h       |  3 --
>
> What about SPI?

That include file should technically be in the backlight
include path or platform_data (yeah someone should
fix...) but let's ask Mark explicitly if this is OK.

Mark: the hunk hitting the include/linux/spi/corgi_lcd.h
file looks like this:

@@ -11,9 +11,6 @@ struct corgi_lcd_platform_data {
        int     default_intensity;
        int     limit_mask;

-       int     gpio_backlight_on;      /* -1 if n/a */
-       int     gpio_backlight_cont;    /* -1 if n/a */
-
        void (*notify)(int intensity);
        void (*kick_battery)(void);
 };

OK with you? If you want I can resend the whole patch
as well so you can have a look.

Yours,
Linus Walleij
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
