From: Linus Walleij <linus.walleij@linaro.org>
To: He Zhe <zhe.he@windriver.com>, Chris Sorenson <csoren@isd.net>
Cc: Drew Fustini <drew@beagleboard.org>,
Andy Shevchenko <andy.shevchenko@gmail.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: core: Add missing #ifdef CONFIG_GPIOLIB
Date: Thu, 5 Nov 2020 14:53:29 +0100 [thread overview]
Message-ID: <CACRpkdZOcObSgRDPtjxB69VeM1FEeSsPJ8SZ=RqWOT2fEN0ynw@mail.gmail.com> (raw)
In-Reply-To: <20201028103921.22486-1-zhe.he@windriver.com>
On Wed, Oct 28, 2020 at 11:40 AM He Zhe <zhe.he@windriver.com> wrote:
> To fix the following build warnings when CONFIG_GPIOLIB=n.
>
> drivers/pinctrl/core.c:1607:20: warning: unused variable 'chip' [-Wunused-variable]
> 1608 | struct gpio_chip *chip;
> | ^~~~
> drivers/pinctrl/core.c:1606:15: warning: unused variable 'gpio_num' [-Wunused-variable]
> 1607 | unsigned int gpio_num;
> | ^~~~~~~~
> drivers/pinctrl/core.c:1605:29: warning: unused variable 'range' [-Wunused-variable]
> 1606 | struct pinctrl_gpio_range *range;
> | ^~~~~
>
> Fixes: f1b206cf7c57 ("pinctrl: core: print gpio in pins debugfs file")
> Signed-off-by: He Zhe <zhe.he@windriver.com>
Patch applied. I first applied a similar patch by Chris, but I realized
it ended up mixing code and declarations so I'll go for this one instead.
Yours,
Linus Walleij
prev parent reply other threads:[~2020-11-05 13:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-28 10:39 [PATCH] pinctrl: core: Add missing #ifdef CONFIG_GPIOLIB He Zhe
2020-10-28 11:41 ` Andy Shevchenko
2020-11-05 13:53 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZOcObSgRDPtjxB69VeM1FEeSsPJ8SZ=RqWOT2fEN0ynw@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andy.shevchenko@gmail.com \
--cc=csoren@isd.net \
--cc=drew@beagleboard.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhe.he@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.