All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Thierry Reding <thierry.reding@gmail.com>
Cc: Jon Hunter <jonathanh@nvidia.com>,
	Prathamesh Shete <pshete@nvidia.com>,
	linux-gpio@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH 1/2] pinctrl: tegra: Duplicate pinmux functions table
Date: Thu, 1 Jun 2023 13:19:45 +0200	[thread overview]
Message-ID: <CACRpkdaN2r24QrL5t-_SsUQ-9o=BhZx0eFgpbsA+QiFTicPnKg@mail.gmail.com> (raw)
In-Reply-To: <20230530105308.1292852-1-thierry.reding@gmail.com>

On Tue, May 30, 2023 at 12:53 PM Thierry Reding
<thierry.reding@gmail.com> wrote:

> From: Thierry Reding <treding@nvidia.com>
>
> The function table is filled with group information based on other
> instance-specific data at runtime. However, the function table can be
> shared between multiple instances, causing the ->probe() function for
> one instance to overwrite the table of a previously probed instance.
>
> Fix this by sharing only the function names and allocating a separate
> function table for each instance.
>
> Fixes: 5a0047360743 ("pinctrl: tegra: Separate Tegra194 instances")
> Signed-off-by: Thierry Reding <treding@nvidia.com>

Both patches applied!

I can't figure out if the problem is urgent or just wasting memory, so
I applied it as non-urgent fix for now, tell me if this needs to go
upstream pronto.

Yours,
Linus Walleij

  parent reply	other threads:[~2023-06-01 11:19 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-30 10:53 [PATCH 1/2] pinctrl: tegra: Duplicate pinmux functions table Thierry Reding
2023-05-30 10:53 ` [PATCH 2/2] pinctrl: tegra: Consistently refer to SoC data Thierry Reding
2023-06-01 11:19 ` Linus Walleij [this message]
2023-06-01 12:27   ` [PATCH 1/2] pinctrl: tegra: Duplicate pinmux functions table Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdaN2r24QrL5t-_SsUQ-9o=BhZx0eFgpbsA+QiFTicPnKg@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=jonathanh@nvidia.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=pshete@nvidia.com \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.