From: Linus Walleij <linus.walleij@linaro.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Mark Brown <broonie@kernel.org>,
Chanwoo Choi <cw00.choi@samsung.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max77686: fix obtaining "maxim,ena" GPIO
Date: Thu, 12 Sep 2019 10:22:59 +0100 [thread overview]
Message-ID: <CACRpkdaQUVy_k_zvGBF3V4fNvVWKFa-st=RdtbjSQ817a0BSTg@mail.gmail.com> (raw)
In-Reply-To: <20190910170050.GA55530@dtor-ws>
On Tue, Sep 10, 2019 at 6:00 PM Dmitry Torokhov
<dmitry.torokhov@gmail.com> wrote:
> This fixes 96392c3d8ca4, as devm_gpiod_get_from_of_node() does
> not do translation "con-id" -> "con-id-gpios" that our bindings expects,
> and therefore it was wrong to change connection ID to be simply
> "maxim,ena" when moving to using devm_gpiod_get_from_of_node().
>
> Fixes: 96392c3d8ca4 ("regulator: max77686: Pass descriptor instead of GPIO number")
> Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
An honest mistake, how typical :/
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2019-09-12 9:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-10 17:00 [PATCH] regulator: max77686: fix obtaining "maxim,ena" GPIO Dmitry Torokhov
2019-09-11 14:59 ` Applied "regulator: max77686: fix obtaining "maxim,ena" GPIO" to the regulator tree Mark Brown
2019-09-12 9:22 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdaQUVy_k_zvGBF3V4fNvVWKFa-st=RdtbjSQ817a0BSTg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.