From: Linus Walleij <linus.walleij@linaro.org>
To: Arvind Yadav <arvind.yadav.cs@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Linux Input <linux-input@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] input: keyboard: constify attribute_group structures.
Date: Mon, 31 Jul 2017 15:42:00 +0200 [thread overview]
Message-ID: <CACRpkdbv+8_U8Xhdwo2Ry4p+128pe5ChkvwsfGJgqab2Ri2NZQ@mail.gmail.com> (raw)
In-Reply-To: <5c9063817d021c487f3429a4fee60fa84e0e93d6.1499251467.git.arvind.yadav.cs@gmail.com>
On Wed, Jul 5, 2017 at 12:46 PM, Arvind Yadav <arvind.yadav.cs@gmail.com> wrote:
> attribute_groups are not supposed to change at runtime. All functions
> working with attribute_groups provided by <linux/sysfs.h> work with const
> attribute_group. So mark the non-const structs as const.
>
> File size before:
> text data bss dec hex filename
> 5693 464 0 6157 180d drivers/input/keyboard/gpio_keys.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 5749 400 0 6149 1805 drivers/input/keyboard/gpio_keys.o
>
> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
prev parent reply other threads:[~2017-07-31 13:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-05 10:46 [PATCH] input: keyboard: constify attribute_group structures Arvind Yadav
2017-07-31 13:42 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdbv+8_U8Xhdwo2Ry4p+128pe5ChkvwsfGJgqab2Ri2NZQ@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=arvind.yadav.cs@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.