From: KP Singh <kpsingh@kernel.org>
To: Roberto Sassu <roberto.sassu@huaweicloud.com>
Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
martin.lau@linux.dev, song@kernel.org, yhs@fb.com,
john.fastabend@gmail.com, sdf@google.com, haoluo@google.com,
jolsa@kernel.org, mykolal@fb.com, revest@chromium.org,
jackmanb@chromium.org, shuah@kernel.org, paul@paul-moore.com,
casey@schaufler-ca.com, zohar@linux.ibm.com, bpf@vger.kernel.org,
linux-security-module@vger.kernel.org,
linux-integrity@vger.kernel.org, linux-kselftest@vger.kernel.org,
linux-kernel@vger.kernel.org, nicolas.bouchinet@clip-os.org
Subject: Re: [RESEND][RFC][PATCH 1/3] lsm: Clarify documentation of vm_enough_memory hook
Date: Thu, 3 Nov 2022 16:11:13 +0100 [thread overview]
Message-ID: <CACYkzJ5nwsdaG57HHkNubPptkB=_Mz68TVzmX8+Tg=ZFjMX3pw@mail.gmail.com> (raw)
In-Reply-To: <20221028165423.386151-1-roberto.sassu@huaweicloud.com>
On Fri, Oct 28, 2022 at 6:55 PM Roberto Sassu
<roberto.sassu@huaweicloud.com> wrote:
>
> From: Roberto Sassu <roberto.sassu@huawei.com>
>
> include/linux/lsm_hooks.h reports the result of the LSM infrastructure to
> the callers, not what LSMs should return to the LSM infrastructure.
>
> Clarify that and add that returning 1 from the LSMs means calling
> __vm_enough_memory() with cap_sys_admin set, 0 without.
>
> Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com>
Reviewed-by: KP Singh <kpsingh@kernel.org>
> ---
> include/linux/lsm_hooks.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/linux/lsm_hooks.h b/include/linux/lsm_hooks.h
> index 4ec80b96c22e..f40b82ca91e7 100644
> --- a/include/linux/lsm_hooks.h
> +++ b/include/linux/lsm_hooks.h
> @@ -1411,7 +1411,9 @@
> * Check permissions for allocating a new virtual mapping.
> * @mm contains the mm struct it is being added to.
> * @pages contains the number of pages.
> - * Return 0 if permission is granted.
> + * Return 0 if permission is granted by LSMs to the caller. LSMs should
> + * return 1 if __vm_enough_memory() should be called with
> + * cap_sys_admin set, 0 if not.
> *
> * @ismaclabel:
> * Check if the extended attribute specified by @name
> --
> 2.25.1
>
prev parent reply other threads:[~2022-11-03 15:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 16:54 [RESEND][RFC][PATCH 1/3] lsm: Clarify documentation of vm_enough_memory hook Roberto Sassu
2022-10-28 16:54 ` [RESEND][RFC][PATCH 2/3] bpf-lsm: Limit values that can be returned by security modules Roberto Sassu
2022-11-03 15:09 ` KP Singh
2022-11-04 15:28 ` Roberto Sassu
2022-11-05 0:42 ` Alexei Starovoitov
2022-11-07 12:32 ` Roberto Sassu
2022-11-07 16:00 ` Alexei Starovoitov
2022-11-07 16:19 ` Roberto Sassu
2022-10-28 16:54 ` [RESEND][RFC][PATCH 3/3] selftests/bpf: Check if return values of LSM programs are allowed Roberto Sassu
2022-11-03 15:11 ` KP Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACYkzJ5nwsdaG57HHkNubPptkB=_Mz68TVzmX8+Tg=ZFjMX3pw@mail.gmail.com' \
--to=kpsingh@kernel.org \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=casey@schaufler-ca.com \
--cc=daniel@iogearbox.net \
--cc=haoluo@google.com \
--cc=jackmanb@chromium.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=martin.lau@linux.dev \
--cc=mykolal@fb.com \
--cc=nicolas.bouchinet@clip-os.org \
--cc=paul@paul-moore.com \
--cc=revest@chromium.org \
--cc=roberto.sassu@huaweicloud.com \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=yhs@fb.com \
--cc=zohar@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.