All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@google.com>
To: linux-integrity <linux-integrity@vger.kernel.org>
Cc: Mimi Zohar <zohar@linux.vnet.ibm.com>,
	linux-crypto@vger.kernel.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	davem@davemloft.net
Subject: Re: [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable
Date: Tue, 12 Jun 2018 10:43:16 -0700	[thread overview]
Message-ID: <CACdnJuuop-rosGXBqkLZrMszuxhy-JeQGKrj7aFJNSe4NWBNog@mail.gmail.com> (raw)
In-Reply-To: <20180608215743.224253-2-mjg59@google.com>

On Fri, Jun 8, 2018 at 2:57 PM Matthew Garrett <mjg59@google.com> wrote:
>
> When EVM attempts to appraise a file signed with a crypto algorithm the
> kernel doesn't have support for, it will cause the kernel to trigger a
> module load. If the EVM policy includes appraisal of kernel modules this
> will in turn call back into EVM - since EVM is holding a lock until the
> crypto initialisation is complete, this triggers a deadlock. Add a
> CRYPTO_NOLOAD flag and skip module loading if it's set, and add that flag
> in the EVM case in order to fail gracefully with an error message
> instead of deadlocking.

Hi Herbert,

Does this explain the problem sufficiently?

  reply	other threads:[~2018-06-12 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-06-08 21:57 Support additional signature types in EVM Matthew Garrett
2018-06-08 21:57 ` [PATCH V3 1/2] evm: Don't deadlock if a crypto algorithm is unavailable Matthew Garrett
2018-06-12 17:43   ` Matthew Garrett [this message]
2018-06-13  6:33   ` Herbert Xu
2018-06-13 13:50     ` Mimi Zohar
2018-06-08 21:57 ` [PATCH V3 2/2] evm: Allow non-SHA1 digital signatures Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACdnJuuop-rosGXBqkLZrMszuxhy-JeQGKrj7aFJNSe4NWBNog@mail.gmail.com \
    --to=mjg59@google.com \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-integrity@vger.kernel.org \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.