Re: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info

From: Prashant Malani <pmalani@chromium.org>
To: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Cc: Tzung-Bi Shih <tzungbi@kernel.org>,
	linux-kernel@vger.kernel.org,  chrome-platform@lists.linux.dev,
	bleung@chromium.org,
	 Enric Balletbo i Serra <enric.balletbo@collabora.com>,
	Guenter Roeck <groeck@chromium.org>
Subject: Re: [PATCH 3/4] platform/chrome: cros_ec_typec: Stash port driver info
Date: Tue, 23 Aug 2022 10:52:39 -0700	[thread overview]
Message-ID: <CACeCKae8YYQUk0dKKbuq-S-3D4=rPFHyjwgK7b55q_T=u9QjLw@mail.gmail.com> (raw)
In-Reply-To: <YwSNCFt48Q9Eo02I@kuha.fi.intel.com>

Thanks for the reviews folks.

On Tue, Aug 23, 2022 at 1:17 AM Heikki Krogerus
<heikki.krogerus@linux.intel.com> wrote:
>
> On Tue, Aug 23, 2022 at 04:43:41AM +0000, Tzung-Bi Shih wrote:
> > On Fri, Aug 19, 2022 at 07:08:04PM +0000, Prashant Malani wrote:
> > > Stash port number and a pointer to the driver-specific struct in the
> > > local Type-C port struct.
> > >
> > > These can be useful to the port driver to figure out how to communicate
> > > with the ChromeOS EC when an altmode driver related callback is invoked
> > > from the Type-C class code.
> >
> > The patch looks good to me.  But I would suggest to send it in later series
> > that uses the driver-specific struct (e.g. in altmode driver related callbacks)
> > to make the usage clear.
>
> I agree.

Ok. I will resend this along with the alt mode series.

BR,

-Prashant