From: Oder <oder_chiou@realtek.com>
To: Mark Brown <broonie@kernel.org>
Cc: Oder Chiou <oder_chiou@realtek.com>,
Bard Liao <bardliao@realtek.com>,
alsa-devel@alsa-project.org, lgirdwood@gmail.com,
Flove <flove@realtek.com>
Subject: Re: [PATCH] ASoC: rt5645: Add codec driver
Date: Tue, 22 Apr 2014 09:04:31 +0800 [thread overview]
Message-ID: <CAD+35SOp8qTv3OSHVj_L7Z-crsgq1kHHNrpAiekh6oOa7tXCSg@mail.gmail.com> (raw)
In-Reply-To: <20140414202837.GA25182@sirena.org.uk>
>
> > +static int rt5645_set_bias_level(struct snd_soc_codec *codec,
> > + enum snd_soc_bias_level level)
> > +{
> > + switch (level) {
> > + case SND_SOC_BIAS_STANDBY:
> > + if (SND_SOC_BIAS_OFF == codec->dapm.bias_level) {
> > + snd_soc_update_bits(codec, RT5645_PWR_ANLG1,
> > + RT5645_PWR_VREF1 | RT5645_PWR_MB |
> > + RT5645_PWR_BG | RT5645_PWR_VREF2,
> > + RT5645_PWR_VREF1 | RT5645_PWR_MB |
> > + RT5645_PWR_BG | RT5645_PWR_VREF2);
> > + mdelay(10);
> > + snd_soc_update_bits(codec, RT5645_PWR_ANLG1,
> > + RT5645_PWR_FV1 | RT5645_PWR_FV2,
> > + RT5645_PWR_FV1 | RT5645_PWR_FV2);
> > + snd_soc_update_bits(codec, RT5645_GEN_CTRL1,
> > + RT5645_DIG_GATE_CTRL,
> RT5645_DIG_GATE_CTRL);
> > + }
> > + break;
>
> Since the device can power up and down very quickly it should make sense
> to set idle_bias_off for a power saving when idle.
We've set the idle_bias_off as true in struct "soc_codec_dev_rt5645", is
there any thing i miss it?
next prev parent reply other threads:[~2014-04-22 1:04 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-11 10:34 [PATCH] ASoC: rt5645: Add codec driver Oder Chiou
2014-04-14 20:28 ` Mark Brown
2014-04-22 1:04 ` Oder [this message]
2014-04-22 1:10 ` Oder
2014-04-22 10:53 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+35SOp8qTv3OSHVj_L7Z-crsgq1kHHNrpAiekh6oOa7tXCSg@mail.gmail.com \
--to=oder_chiou@realtek.com \
--cc=alsa-devel@alsa-project.org \
--cc=bardliao@realtek.com \
--cc=broonie@kernel.org \
--cc=flove@realtek.com \
--cc=lgirdwood@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.