From: harshad shirwadkar <harshadshirwadkar@gmail.com>
To: Xin Yin <yinxin.x@bytedance.com>
Cc: "Theodore Y. Ts'o" <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Ext4 Developers List <linux-ext4@vger.kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/2] ext4: fast commit crash consistency issues
Date: Thu, 23 Dec 2021 12:13:22 -0800 [thread overview]
Message-ID: <CAD+ocbxLHJ2KK44gT0u7zei--UBJ1CRRKyra8Hhx1CvtCcOpQA@mail.gmail.com> (raw)
In-Reply-To: <20211223032337.5198-1-yinxin.x@bytedance.com>
Thanks for the patches, these are good finds.
Reviewed-by: Harshad Shirwadkar <harshadshirwadkar@gmail.com>
On Wed, Dec 22, 2021 at 7:24 PM Xin Yin <yinxin.x@bytedance.com> wrote:
>
> This patch sets fix 2 crash-consistency issues of fast commit.
> First patch change to use ext4_ext_remove_space instead of
> ext4_punch_hole during replay delete range procedure. This
> avoid replay procedure being affeced by incorrect inode->i_size.
> Second patch correct the trank range logic for ftruncte.
>
> After testing this patch sets with xfstests-bld, in the "log" and
> "quick" group with config "fast_commit" is selected. No regressions
> was found.
>
> Signed-off-by: Xin Yin <yinxin.x@bytedance.com>
>
> Xin Yin (2):
> ext4: use ext4_ext_remove_space() for fast commit replay delete range
> ext4: fast commit may miss tracking unwritten range during ftruncate
>
> fs/ext4/fast_commit.c | 13 ++++++++-----
> fs/ext4/inode.c | 3 +--
> 2 files changed, 9 insertions(+), 7 deletions(-)
>
> --
> 2.20.1
>
next prev parent reply other threads:[~2021-12-23 20:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-23 3:23 [PATCH 0/2] ext4: fast commit crash consistency issues Xin Yin
2021-12-23 3:23 ` [PATCH 1/2] ext4: use ext4_ext_remove_space() for fast commit replay delete range Xin Yin
2021-12-23 20:11 ` harshad shirwadkar
2022-02-01 20:33 ` Ritesh Harjani
2022-02-02 13:40 ` [External] " Xin Yin
2022-02-03 21:14 ` Ritesh Harjani
2022-02-04 11:36 ` Jan Kara
2022-02-05 10:40 ` Ritesh Harjani
2021-12-23 3:23 ` [PATCH 2/2] ext4: fast commit may miss tracking unwritten range during ftruncate Xin Yin
2021-12-23 20:11 ` harshad shirwadkar
2021-12-23 20:13 ` harshad shirwadkar [this message]
2021-12-24 0:27 ` [PATCH 0/2] ext4: fast commit crash consistency issues Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAD+ocbxLHJ2KK44gT0u7zei--UBJ1CRRKyra8Hhx1CvtCcOpQA@mail.gmail.com \
--to=harshadshirwadkar@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=yinxin.x@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.