From: Doug Anderson <dianders@chromium.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: "Jakub Kicinski" <kuba@kernel.org>,
"Hayes Wang" <hayeswang@realtek.com>,
"David S . Miller" <davem@davemloft.net>,
"Grant Grundler" <grundler@chromium.org>,
"Simon Horman" <horms@kernel.org>,
"Edward Hill" <ecgh@chromium.org>,
linux-usb@vger.kernel.org, "Laura Nao" <laura.nao@collabora.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Bjørn Mork" <bjorn@mork.no>,
"Eric Dumazet" <edumazet@google.com>,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH 2/2] r8152: Add RTL8152_INACCESSIBLE checks to more loops
Date: Tue, 21 Nov 2023 09:55:46 -0800 [thread overview]
Message-ID: <CAD=FV=VALvcLr+HbdvEen109qT3Z5EL0u4tiefTs3AH8EHXFnA@mail.gmail.com> (raw)
In-Reply-To: <4fa33b0938031d7339dbc89a415864b6d041d0c3.camel@redhat.com>
Hi,
On Tue, Nov 21, 2023 at 2:28 AM Paolo Abeni <pabeni@redhat.com> wrote:
>
> On Fri, 2023-11-17 at 13:08 -0800, Douglas Anderson wrote:
> > Previous commits added checks for RTL8152_INACCESSIBLE in the loops in
> > the driver. There are still a few more that keep tripping the driver
> > up in error cases and make things take longer than they should. Add
> > those in.
> >
> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
>
> I think this deserves a 'Fixes' tag. Please add it.
Sure, I can add it. It didn't feel worth it to me since there's no
real functional issue--just that it takes a little longer for these
loops to exit out, but it shouldn't hurt. I guess that means breaking
this commit into several depending on when the offending loop was
added.
> Additionally please insert the target tree in the subj prefix when re-
> postin (in this case 'net')
Funny, I just followed the tags for other commits to this file and the
"net:" prefix isn't common. I guess this should be "net: usb: r8152".
I can add it when I post v2.
next prev parent reply other threads:[~2023-11-21 17:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-17 21:08 [PATCH 1/2] r8152: Hold the rtnl_lock for all of reset Douglas Anderson
2023-11-17 21:08 ` [PATCH 2/2] r8152: Add RTL8152_INACCESSIBLE checks to more loops Douglas Anderson
2023-11-21 3:26 ` Grant Grundler
2023-11-21 10:28 ` Paolo Abeni
2023-11-21 17:55 ` Doug Anderson [this message]
2023-11-23 14:24 ` Simon Horman
2023-11-21 3:23 ` [PATCH 1/2] r8152: Hold the rtnl_lock for all of reset Grant Grundler
2023-11-21 10:25 ` Paolo Abeni
2023-11-21 17:41 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=VALvcLr+HbdvEen109qT3Z5EL0u4tiefTs3AH8EHXFnA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=ecgh@chromium.org \
--cc=edumazet@google.com \
--cc=grundler@chromium.org \
--cc=hayeswang@realtek.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=laura.nao@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.