Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip

From: Doug Anderson <dianders@google.com>
To: William Wu <william.wu@rock-chips.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Felipe Balbi" <balbi@kernel.org>,
	"Heiko Stübner" <heiko@sntech.de>,
	"Brian Norris" <briannorris@google.com>,
	"Kever Yang" <kever.yang@rock-chips.com>,
	"Tao Huang" <huangtao@rock-chips.com>,
	frank.wang@rock-chips.com, "Eddie Cai" <eddie.cai@rock-chips.com>,
	"John Youn" <John.Youn@synopsys.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 1/4] usb: dwc3: of-simple: add compatible for rockchip
Date: Mon, 9 May 2016 08:16:44 -0700	[thread overview]
Message-ID: <CAD=FV=Vykw82DF51nYX-sVOM6E35R35W8_m3G1bNRnrqvyBzEQ@mail.gmail.com> (raw)
In-Reply-To: <1462794377-6528-2-git-send-email-william.wu@rock-chips.com>

William,

On Mon, May 9, 2016 at 4:46 AM, William Wu <william.wu@rock-chips.com> wrote:
> Signed-off-by: William Wu <william.wu@rock-chips.com>
> ---
>  drivers/usb/dwc3/dwc3-of-simple.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/usb/dwc3/dwc3-of-simple.c b/drivers/usb/dwc3/dwc3-of-simple.c
> index 9743353..1f3665b 100644
> --- a/drivers/usb/dwc3/dwc3-of-simple.c
> +++ b/drivers/usb/dwc3/dwc3-of-simple.c
> @@ -162,6 +162,7 @@ static const struct dev_pm_ops dwc3_of_simple_dev_pm_ops = {
>  static const struct of_device_id of_dwc3_simple_match[] = {
>         { .compatible = "qcom,dwc3" },
>         { .compatible = "xlnx,zynqmp-dwc3" },
> +       { .compatible = "rockchip,dwc3" },

It is, of course, up to Felipe.  ...but personally I'd prefer that
things here be sorted alphabetically.  Sorting things in a consistent
manner tends to reduce merge conflicts as the list gets longer and
also makes it easier to find things.

-Doug