From: Doug Anderson <dianders@chromium.org>
To: Jiri Kosina <jkosina@suse.cz>,
Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Andrea Borgia <andrea@borgia.bo.it>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
linux-input@vger.kernel.org, Stephen Boyd <swboyd@chromium.org>,
Hans de Goede <hdegoede@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P
Date: Fri, 23 Oct 2020 16:30:09 -0700 [thread overview]
Message-ID: <CAD=FV=XnXCL0xrDoxpdaeQv5rut7Vpryor20KR4sHR_344_LcA@mail.gmail.com> (raw)
In-Reply-To: <20201023162220.v2.2.Ibb28033c81d87fcc13a6ba28c6ea7ac154d65f93@changeid>
Hi,
On Fri, Oct 23, 2020 at 4:23 PM Douglas Anderson <dianders@chromium.org> wrote:
>
> +examples:
> + - |
> + #include <dt-bindings/clock/qcom,rpmh.h>
> + #include <dt-bindings/gpio/gpio.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + ap_ts: touchscreen@5d {
> + compatible = "hid-over-i2c";
You always find one more problem right after you hit send, don't you?
Or is that just me?
Obviously the above should say
compatible = "goodix,gt7375p";
Luckily when I change that "dt_binding_check" still passes. Whew!
I won't send a v3 yet and I'll wait for feedback. On the off chance
that there are no other problems with this binding and the maintainer
wants to land this, I don't have any objections to the maintainer
fixing this when the patch lands.
-Doug
next prev parent reply other threads:[~2020-10-23 23:30 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-23 23:22 [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated Douglas Anderson
2020-10-23 23:22 ` [PATCH v2 2/3] dt-bindings: HID: i2c-hid: Introduce bindings for the Goodix GT7375P Douglas Anderson
2020-10-23 23:30 ` Doug Anderson [this message]
2020-10-30 10:52 ` Benjamin Tissoires
2020-10-23 23:22 ` [PATCH v2 3/3] HID: i2c-hid: Support the Goodix GT7375P touchscreen Douglas Anderson
2020-10-30 11:01 ` Benjamin Tissoires
2020-10-30 10:51 ` [PATCH v2 1/3] dt-bindings: HID: i2c-hid: Label this binding as deprecated Benjamin Tissoires
2020-10-30 18:00 ` Rob Herring
2020-10-30 19:12 ` Benjamin Tissoires
2020-10-30 20:11 ` Dmitry Torokhov
2020-11-03 0:18 ` Doug Anderson
2020-10-30 16:47 ` Rob Herring
2020-11-03 0:16 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=FV=XnXCL0xrDoxpdaeQv5rut7Vpryor20KR4sHR_344_LcA@mail.gmail.com' \
--to=dianders@chromium.org \
--cc=andrea@borgia.bo.it \
--cc=benjamin.tissoires@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=jkosina@suse.cz \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.