Re: [PATCH net] forcedeth: Fix an error handling path in nv_probe()

From: Zhu Yanjun <zyjzyj2000@gmail.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Rain River <rain.1986.08.12@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Ayaz Abdulla <aabdulla@nvidia.com>,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH net] forcedeth: Fix an error handling path in nv_probe()
Date: Sat, 20 May 2023 18:51:50 +0800	[thread overview]
Message-ID: <CAD=hENdwa-_LsQNUmd44ZCtidGOyAsdDpngAjpSZyAj78yfFUQ@mail.gmail.com> (raw)
In-Reply-To: <355e9a7d351b32ad897251b6f81b5886fcdc6766.1684571393.git.christophe.jaillet@wanadoo.fr>

On Sat, May 20, 2023 at 4:30 PM Christophe JAILLET
<christophe.jaillet@wanadoo.fr> wrote:
>
> If an error occures after calling nv_mgmt_acquire_sema(), it should be
> undone with a corresponding nv_mgmt_release_sema() call.
>
> Add it in the error handling path of the probe as already done in the
> remove function.
>
> Fixes: cac1c52c3621 ("forcedeth: mgmt unit interface")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

Thanks.
Acked-by: Zhu Yanjun <zyjzyj2000@gmail.com>

Zhu Yanjun
> ---
> I don't think that the Fixes tag is really accurate, but
> nv_mgmt_release_sema() was introduced here. And cac1c52c3621 is already old
> so should be good enough.
> ---
>  drivers/net/ethernet/nvidia/forcedeth.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/nvidia/forcedeth.c b/drivers/net/ethernet/nvidia/forcedeth.c
> index 0605d1ee490d..7a549b834e97 100644
> --- a/drivers/net/ethernet/nvidia/forcedeth.c
> +++ b/drivers/net/ethernet/nvidia/forcedeth.c
> @@ -6138,6 +6138,7 @@ static int nv_probe(struct pci_dev *pci_dev, const struct pci_device_id *id)
>         return 0;
>
>  out_error:
> +       nv_mgmt_release_sema(dev);
>         if (phystate_orig)
>                 writel(phystate|NVREG_ADAPTCTL_RUNNING, base + NvRegAdapterControl);
>  out_freering:
> --
> 2.34.1
>