From: zhuyj <zyjzyj2000@gmail.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Sargun Dhillon <sargun@sargun.me>,
LKML <linux-kernel@vger.kernel.org>,
alexei.starovoitov@gmail.com, daniel@iogearbox.net,
linux-security-module@vger.kernel.org,
netdev <netdev@vger.kernel.org>
Subject: Re: [RFC 2/4] bpf, security: Add Checmate
Date: Thu, 4 Aug 2016 17:34:32 +0800 [thread overview]
Message-ID: <CAD=hENeWDNTQ8oQurdX6kHxuuRVh-DtEDEDH0=-BCM9mqzZn6g@mail.gmail.com> (raw)
In-Reply-To: <1470299302.13693.13.camel@edumazet-glaptop3.roam.corp.google.com>
Sure.
Is it better to add
#ifndef CONFIG_PREEMPT_RCU ?
On Thu, Aug 4, 2016 at 4:28 PM, Eric Dumazet <eric.dumazet@gmail.com> wrote:
> Please do not top post
>
> On Thu, 2016-08-04 at 16:08 +0800, zhuyj wrote:
>> +void register_checmate_prog_ops(void);
>> maybe it is extern void register_checmate_prog_ops(void);?
>>
>> + preempt_disable();
>> + rcu_read_lock();
>> IMHO, it is not necessary to use the above 2 since rcu_read_lock will
>> call preempt_disable.
>
> You might double check if this claim is true if CONFIG_PREEMPT_RCU=y
>
>
>
next prev parent reply other threads:[~2016-08-04 9:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-04 7:11 [RFC 2/4] bpf, security: Add Checmate Sargun Dhillon
2016-08-04 8:08 ` zhuyj
2016-08-04 8:28 ` Eric Dumazet
2016-08-04 9:34 ` zhuyj [this message]
2016-08-05 7:05 ` Sargun Dhillon
2016-08-05 7:45 ` zhuyj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAD=hENeWDNTQ8oQurdX6kHxuuRVh-DtEDEDH0=-BCM9mqzZn6g@mail.gmail.com' \
--to=zyjzyj2000@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=daniel@iogearbox.net \
--cc=eric.dumazet@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sargun@sargun.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.