Re: [PATCH libdrm 13/17] tests/amdgpu: annotate (most of) the vce templates as const data

From: Alex Deucher <alexdeucher@gmail.com>
To: Emil Velikov <emil.l.velikov@gmail.com>
Cc: Alex Deucher <alexander.deucher@amd.com>,
	Leo Liu <leo.liu@amd.com>,
	Maling list - DRI developers <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH libdrm 13/17] tests/amdgpu: annotate (most of) the vce templates as const data
Date: Mon, 24 Aug 2015 13:07:39 -0400	[thread overview]
Message-ID: <CADnq5_M8noSXuTOO7apsu9RkegDW2aStNCe5Mtb7aJa1ZqvR3w@mail.gmail.com> (raw)
In-Reply-To: <1440434060-31347-13-git-send-email-emil.l.velikov@gmail.com>

On Mon, Aug 24, 2015 at 12:34 PM, Emil Velikov <emil.l.velikov@gmail.com> wrote:
> The remaining two templates are modified on the fly, depending on the
> type of test to be performed.
>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: Leo Liu <leo.liu@amd.com>
> Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>

> ---
>  tests/amdgpu/vce_ib.h | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/tests/amdgpu/vce_ib.h b/tests/amdgpu/vce_ib.h
> index c5afed0..bd0bf94 100644
> --- a/tests/amdgpu/vce_ib.h
> +++ b/tests/amdgpu/vce_ib.h
> @@ -24,7 +24,7 @@
>  #ifndef _vce_ib_h_
>  #define _vce_ib_h_
>
> -static uint32_t vce_session[3] = {
> +static const uint32_t vce_session[] = {
>         0x0000000c,
>         0x00000001,
>         0x400c0001,
> @@ -41,7 +41,7 @@ static uint32_t vce_taskinfo[8] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_create[12] = {
> +static const uint32_t vce_create[] = {
>         0x00000030,
>         0x01000001,
>         0x00000000,
> @@ -56,7 +56,7 @@ static uint32_t vce_create[12] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_rate_ctrl[28] = {
> +static const uint32_t vce_rate_ctrl[] = {
>         0x00000070,
>         0x04000005,
>         0x00000000,
> @@ -87,13 +87,13 @@ static uint32_t vce_rate_ctrl[28] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_config_ext[3] = {
> +static const uint32_t vce_config_ext[] = {
>         0x0000000c,
>         0x04000001,
>         0x00000003,
>  };
>
> -static uint32_t vce_motion_est[26] = {
> +static const uint32_t vce_motion_est[] = {
>         0x00000068,
>         0x04000007,
>         0x00000001,
> @@ -122,7 +122,7 @@ static uint32_t vce_motion_est[26] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_rdo[19] = {
> +static const uint32_t vce_rdo[] = {
>         0x0000004c,
>         0x04000008,
>         0x00000000,
> @@ -144,7 +144,7 @@ static uint32_t vce_rdo[19] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_pic_ctrl[29] = {
> +static const uint32_t vce_pic_ctrl[] = {
>         0x00000074,
>         0x04000002,
>         0x00000000,
> @@ -176,7 +176,7 @@ static uint32_t vce_pic_ctrl[29] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_feedback[5] = {
> +static const uint32_t vce_feedback[] = {
>         0x00000014,
>         0x05000005,
>         0x00000000,
> @@ -184,14 +184,14 @@ static uint32_t vce_feedback[5] = {
>         0x00000001,
>  };
>
> -static uint32_t vce_context_buffer[4] = {
> +static const uint32_t vce_context_buffer[] = {
>         0x00000010,
>         0x05000001,
>         0x00000000,
>         0xffffffff,
>  };
>
> -static uint32_t vce_bs_buffer[5] = {
> +static const uint32_t vce_bs_buffer[] = {
>         0x00000014,
>         0x05000004,
>         0x00000000,
> @@ -199,7 +199,7 @@ static uint32_t vce_bs_buffer[5] = {
>         0x00154000,
>  };
>
> -static uint32_t vce_aux_buffer[18] = {
> +static const uint32_t vce_aux_buffer[] = {
>         0x00000048,
>         0x05000002,
>         0x0000f000,
> @@ -311,7 +311,7 @@ static uint32_t vce_encode[88] = {
>         0x00000000,
>  };
>
> -static uint32_t vce_destroy[2] = {
> +static const uint32_t vce_destroy[] = {
>         0x00000008,
>         0x02000001,
>  };
> --
> 2.5.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel