From: Alex Deucher <alexdeucher@gmail.com>
To: Dave Airlie <airlied@gmail.com>
Cc: "Michel Dänzer" <michel@daenzer.net>,
dri-devel <dri-devel@lists.freedesktop.org>
Subject: Re: [PATCH] drm/radeon: take the mode_config mutex when dealing with hpds
Date: Mon, 18 May 2015 23:28:47 -0400 [thread overview]
Message-ID: <CADnq5_PZ82u8qYqYe3UZE5yw6muh=YamnwkxVr+-0eTkrMDLsw@mail.gmail.com> (raw)
In-Reply-To: <CAPM=9tzJqdJmc2UE9t2zjdkQwEBWkAJJU1_J9MXBtWC1WUfxEQ@mail.gmail.com>
On Mon, May 18, 2015 at 11:24 PM, Dave Airlie <airlied@gmail.com> wrote:
> On 19 May 2015 at 12:27, Michel Dänzer <michel@daenzer.net> wrote:
>> On 19.05.2015 01:24, Alex Deucher wrote:
>>>
>>> @@ -96,10 +98,12 @@ static void radeon_dp_work_func(struct work_struct *work)
>>> struct drm_connector *connector;
>>>
>>> /* this should take a mutex */
>>> + mutex_lock(&mode_config->mutex);
>>
>> This comment can be removed?
>
> I have vague memories of not doing this, because bad things happened.
>
> so keep an eye out for lockdep traces.
I tested the non-MST handling pretty extensively, but I admit I didn't
play with mst. Might be better to split this into two patches.
Alex
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-05-19 3:28 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-18 16:24 [PATCH] drm/radeon: make dpcd parameters const Alex Deucher
2015-05-18 16:24 ` [PATCH] drm/radeon: retry dcpd fetch Alex Deucher
2015-05-18 16:24 ` Alex Deucher
2015-05-18 16:24 ` [PATCH] drm/radeon: take the mode_config mutex when dealing with hpds Alex Deucher
2015-05-18 16:24 ` Alex Deucher
2015-05-19 2:27 ` Michel Dänzer
2015-05-19 3:24 ` Dave Airlie
2015-05-19 3:28 ` Alex Deucher [this message]
2015-05-19 7:49 ` Daniel Vetter
2015-05-18 16:24 ` [PATCH] drm/radeon: properly select encoder in radeon_audio_detect Alex Deucher
2015-05-18 16:24 ` Alex Deucher
2015-05-18 16:24 ` [PATCH] drm/radeon: clean up radeon_audio_enable Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CADnq5_PZ82u8qYqYe3UZE5yw6muh=YamnwkxVr+-0eTkrMDLsw@mail.gmail.com' \
--to=alexdeucher@gmail.com \
--cc=airlied@gmail.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=michel@daenzer.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.