From: Stephen Boyd <swboyd@chromium.org>
To: Doug Anderson <dianders@chromium.org>
Cc: Benson Leung <bleung@chromium.org>,
LKML <linux-kernel@vger.kernel.org>,
chrome-platform@lists.linux.dev,
Guenter Roeck <groeck@chromium.org>,
Craig Hesling <hesling@chromium.org>,
Tom Hughes <tomhughes@chromium.org>,
Alexandru M Stan <amstan@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Matthias Kaehlcke <mka@chromium.org>
Subject: Re: [PATCH v3 3/3] platform/chrome: cros_ec_spi: Boot fingerprint processor during probe
Date: Mon, 21 Mar 2022 19:40:16 +0100 [thread overview]
Message-ID: <CAE-0n501URga+ya37zmWjpZLxMO16CfoLeL2-Ui4qZa1PGK3CQ@mail.gmail.com> (raw)
In-Reply-To: <CAE-0n534-bDXrGUPMxs9qb0F26mO7XyegSt+c4GXKR7ywegcqw@mail.gmail.com>
Quoting Stephen Boyd (2022-03-18 16:36:32)
> Quoting Doug Anderson (2022-03-18 15:06:59)
> > On Fri, Mar 18, 2022 at 3:01 PM Stephen Boyd <swboyd@chromium.org> wrote:
> > >
> > > I'd rather not expose regulator control to userspace through some other
> > > sysfs attribute. Instead I'd prefer the flashing logic that twiddles
> > > gpios and power live all in the kernel and have userspace interact with
> > > a character device to program the firmware.
> >
> > Yeah, that would be even better, you're right.
> >
> > Hmmm, so maybe the answer is to just delay adding the regulator until
> > we're actually ready to specify it correctly and have the flashing
> > happen in the kernel?
> >
>
> I can enable it during probe just so that if the BIOS isn't doing it
> we'll have something that works assuming the DT is actually controlling
> the regulator. Or do nothing. It doesn't matter right now.
Thinking about it more there's no point in controlling the supply here
until we support flashing logic in the kernel. Without flashing support
in the kernel and without the BIOS turning on the power we can simply
make the regulator always-on and boot-on with real gpio control and then
it will be turned on during boot, emulating what the BIOS is doing. The
power cycling after flashing the firmware doesn't seem to be necessary
from my testing. And even then, the flashing script could unbind that
regulator driver if it really needed to control the power.
prev parent reply other threads:[~2022-03-21 18:40 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-18 1:54 [PATCH v3 0/3] Update cros-ec-spi for fingerprint devices Stephen Boyd
2022-03-18 1:54 ` [PATCH v3 1/3] dt-bindings: chrome: Add ChromeOS fingerprint binding Stephen Boyd
2022-03-18 20:49 ` Doug Anderson
2022-03-18 21:12 ` Stephen Boyd
2022-03-18 1:54 ` [PATCH v3 2/3] platform/chrome: cros_ec_spi: Match cros-ec-fp compatible Stephen Boyd
2022-03-18 20:49 ` Doug Anderson
2022-03-18 1:54 ` [PATCH v3 3/3] platform/chrome: cros_ec_spi: Boot fingerprint processor during probe Stephen Boyd
2022-03-18 20:50 ` Doug Anderson
2022-03-18 22:01 ` Stephen Boyd
2022-03-18 22:06 ` Doug Anderson
2022-03-18 23:36 ` Stephen Boyd
2022-03-21 18:40 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAE-0n501URga+ya37zmWjpZLxMO16CfoLeL2-Ui4qZa1PGK3CQ@mail.gmail.com \
--to=swboyd@chromium.org \
--cc=amstan@chromium.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=dianders@chromium.org \
--cc=groeck@chromium.org \
--cc=hesling@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mka@chromium.org \
--cc=tomhughes@chromium.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.