From: Stephen Boyd <swboyd@chromium.org>
To: Deepak Kumar Singh <deesin@codeaurora.org>,
bjorn.andersson@linaro.org, clew@codeaurora.org,
mathieu.poirier@linaro.org
Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-remoteproc@vger.kernel.org,
Ohad Ben-Cohen <ohad@wizery.com>
Subject: Re: [PATCH V1 1/3] rpmsg: core: Add signal API support
Date: Thu, 30 Sep 2021 09:22:49 -0700 [thread overview]
Message-ID: <CAE-0n51KgP1Jc4=eue3xT3=YfwYjdWk7+MOwNrw_FYZ_iX76mA@mail.gmail.com> (raw)
In-Reply-To: <1633015924-881-2-git-send-email-deesin@codeaurora.org>
Quoting Deepak Kumar Singh (2021-09-30 08:32:01)
> Some transports like Glink support the state notifications between
> clients using signals similar to serial protocol signals.
> Local glink client drivers can send and receive signals to glink
> clients running on remote processors.
>
> Add apis to support sending and receiving of signals by rpmsg clients.
s/apis/APIs/
>
> Signed-off-by: Deepak Kumar Singh <deesin@codeaurora.org>
[...]
> diff --git a/drivers/rpmsg/rpmsg_core.c b/drivers/rpmsg/rpmsg_core.c
> index 9151836..5cae50c 100644
> --- a/drivers/rpmsg/rpmsg_core.c
> +++ b/drivers/rpmsg/rpmsg_core.c
> @@ -327,6 +327,24 @@ int rpmsg_trysend_offchannel(struct rpmsg_endpoint *ept, u32 src, u32 dst,
> }
> EXPORT_SYMBOL(rpmsg_trysend_offchannel);
>
> +/**
> + * rpmsg_set_flow_control() - sets/clears searial flow control signals
s/searial/serial/
> + * @ept: the rpmsg endpoint
> + * @enable: enable or disable serial flow control
> + *
> + * Returns 0 on success and an appropriate error value on failure.
Use 'Return:' instead of Returns.
> + */
> +int rpmsg_set_flow_control(struct rpmsg_endpoint *ept, bool enable)
> +{
> + if (WARN_ON(!ept))
> + return -EINVAL;
> + if (!ept->ops->set_flow_control)
> + return -ENXIO;
> +
> + return ept->ops->set_flow_control(ept, enable);
> +}
> +EXPORT_SYMBOL(rpmsg_set_flow_control);
> +
> /*
> * match a rpmsg channel with a channel info struct.
> * this is used to make sure we're not creating rpmsg devices for channels
next prev parent reply other threads:[~2021-09-30 16:22 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 15:32 [PATCH V1 0/3] rpmsg and glink signaling api support Deepak Kumar Singh
2021-09-30 15:32 ` [PATCH V1 1/3] rpmsg: core: Add signal API support Deepak Kumar Singh
2021-09-30 16:22 ` Stephen Boyd [this message]
2021-10-11 18:02 ` Mathieu Poirier
2021-10-16 5:01 ` Bjorn Andersson
2021-10-18 9:00 ` Arnaud POULIQUEN
2021-10-19 2:48 ` Bjorn Andersson
2021-10-18 17:52 ` Mathieu Poirier
2021-10-19 3:05 ` Bjorn Andersson
2021-10-21 17:51 ` Mathieu Poirier
2021-11-06 13:45 ` kernel test robot
2021-11-06 13:45 ` kernel test robot
2021-11-10 6:23 ` kernel test robot
2021-11-10 6:23 ` kernel test robot
2021-09-30 15:32 ` [PATCH 1/1] soc: qcom: smp2p: add feature negotiation and ssr ack feature support Deepak Kumar Singh
2021-09-30 15:44 ` Deepak Kumar Singh
2021-09-30 15:32 ` [PATCH V1 2/3] rpmsg: glink: Add support to handle signals command Deepak Kumar Singh
2021-09-30 16:33 ` Stephen Boyd
2021-11-24 19:17 ` Matthias Kaehlcke
2021-09-30 15:32 ` [PATCH V1 3/3] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Deepak Kumar Singh
2021-09-30 16:36 ` Stephen Boyd
2021-10-11 18:22 ` Mathieu Poirier
2021-10-08 17:54 ` [PATCH V1 0/3] rpmsg and glink signaling api support Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE-0n51KgP1Jc4=eue3xT3=YfwYjdWk7+MOwNrw_FYZ_iX76mA@mail.gmail.com' \
--to=swboyd@chromium.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=deesin@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.