Re: [PATCH] x86/vdso: shrink vdso/extable.i via IWYU

From: Tanzir Hasan <tanzirh@google.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>,
	 Dave Hansen <dave.hansen@linux.intel.com>,
	x86@kernel.org,  "H. Peter Anvin" <hpa@zytor.com>,
	linux-kernel@vger.kernel.org,  Nick Desaulniers <nnn@google.com>
Subject: Re: [PATCH] x86/vdso: shrink vdso/extable.i via IWYU
Date: Thu, 28 Dec 2023 14:01:20 -0800	[thread overview]
Message-ID: <CAE-cH4rEWU-+ovwo8_-i3b2F8pK17kORJ3gV5tnjnUpRJA+B0Q@mail.gmail.com> (raw)
In-Reply-To: <20231228212511.GCZY3nt3gKI+aDvSF1@fat_crate.local>

Hi Boris,

> Maybe I'm missing something but this sounds like the build-time
> "improvement" is so minute that you have to look at preprocessed sizes.
>
> Do you have any, more "noticeable" numbers to justify this churn?

These changes are mainly targeted at reducing preprocessing size which is why
it was brought up. You're not wrong about build times. The changes in build time
are small. To build the original file as is, it takes .69 seconds on
average on my
devices. This changes it to be .55 seconds on average so ~17%.

The intention with these changes is to add up the impact of these small changes
over time to improve build time and also use more direct inclusions where
possible.

Best,
Tanzir