From: Slavomir Kaslev <slavomir.kaslev@gmail.com>
To: Yordan Karadzhov <ykaradzhov@vmware.com>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-trace-devel@vger.kernel.org,
"Yordan Karadzhov (VMware)" <y.karadz@gmail.com>
Subject: Re: [PATCH 1/2] kernel-shark: Enforce update of the OpenGL widget when loading new session
Date: Fri, 3 May 2019 11:25:45 +0300 [thread overview]
Message-ID: <CAE0o1NsNek55HvAfiuOT2zn+B_PxAUuBbhr2Vx=EerWv_Heucg@mail.gmail.com> (raw)
In-Reply-To: <20190502124536.32463-1-ykaradzhov@vmware.com>
On Thu, May 2, 2019 at 3:46 PM Yordan Karadzhov <ykaradzhov@vmware.com> wrote:
>
> This is needed in the case when the session was saved at different screen
> resolution.
>
> Reported-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> Signed-off-by: Yordan Karadzhov <ykaradzhov@vmware.com>
> ---
> kernel-shark/src/KsGLWidget.hpp | 2 ++
> kernel-shark/src/KsMainWindow.cpp | 3 +--
> kernel-shark/src/KsTraceGraph.cpp | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
Both patches look good to me
Reviewed-by: Slavomir Kaslev <kaslevs@vmware.com>
Cheers,
-- Slavi
prev parent reply other threads:[~2019-05-03 8:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-02 12:45 [PATCH 1/2] kernel-shark: Enforce update of the OpenGL widget when loading new session Yordan Karadzhov
2019-05-02 12:45 ` [PATCH 2/2] kernel-shark: Add "Report bug" button to "Help" Yordan Karadzhov
2019-05-03 8:25 ` Slavomir Kaslev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE0o1NsNek55HvAfiuOT2zn+B_PxAUuBbhr2Vx=EerWv_Heucg@mail.gmail.com' \
--to=slavomir.kaslev@gmail.com \
--cc=linux-trace-devel@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=y.karadz@gmail.com \
--cc=ykaradzhov@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.