From: Pany <pany@fedoraproject.org>
To: "M. Vefa Bicakci" <m.v.b@runbox.com>
Cc: Bastien Nocera <hadess@hadess.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, Alan Stern <stern@rowland.harvard.edu>
Subject: Re: [PATCH 1/2] usbcore: Check both id_table and match() when both available
Date: Thu, 29 Oct 2020 05:35:16 +0000 [thread overview]
Message-ID: <CAE3RAxsaUa=dEaSj7dVH1jtzGQpf1-4uMvDRxZnTpEBW+WpsoQ@mail.gmail.com> (raw)
In-Reply-To: <299d5037-f8d7-b71a-f7e7-3a52c06221d2@runbox.com>
On Thu, Oct 29, 2020 at 3:34 AM M. Vefa Bicakci <m.v.b@runbox.com> wrote:
>
> On 28/10/2020 00.00, Pany wrote:
> > On Tue, Oct 27, 2020 at 6:25 PM Bastien Nocera <hadess@hadess.net> wrote:
> >>
> >> On Thu, 2020-10-22 at 09:55 -0400, M. Vefa Bicakci wrote:
> >>> From: Bastien Nocera <hadess@hadess.net>
> >>>
> >>> From: Bastien Nocera <hadess@hadess.net>
> >>>
> >>> When a USB device driver has both an id_table and a match() function,
> >>> make
> >>> sure to check both to find a match, first matching the id_table, then
> >>> checking the match() function.
> >>>
> >>> This makes it possible to have module autoloading done through the
> >>> id_table when devices are plugged in, before checking for further
> >>> device eligibility in the match() function.
> >>>
> >>> Signed-off-by: Bastien Nocera <hadess@hadess.net>
> >>> Cc: <stable@vger.kernel.org> # 5.8
> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >>> Cc: Alan Stern <stern@rowland.harvard.edu>
> >>> Co-developed-by: M. Vefa Bicakci <m.v.b@runbox.com>
> >>> Signed-off-by: M. Vefa Bicakci <m.v.b@runbox.com>
> >>
> >> You can also add my:
> >> Tested-by: Bastien Nocera <hadess@hadess.net>
> >>
> >
> > This patch works well for me.
> > Tested-by: Pan (Pany) YUAN <pany@fedoraproject.org>
>
> I realize that I am a bit late to do this, but I would like to thank
> Bastien and Pany for their efforts in testing (Bastien and Pany) and
> co-developing (Bastien) the patches.
>
> Thanks as well to Greg Kroah-Hartman for committing the patches to
> the usb-linus branch of the usb git tree and for fixing up the patch
> descriptions while doing so.
>
> Thanks everyone!
>
> Vefa
Thanks to Vefa, Bastien, and everyone for all your efforts! The patch
is perfect.
I’m so honored to be part of this. Thanks again.
--
Regards,
Pany
pany@fedoraproject.org
next prev parent reply other threads:[~2020-10-29 7:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-17 16:07 Bug caused by 53965c79c2db (USB: Fix device driver race) Pany
2020-10-17 20:02 ` Alan Stern
2020-10-19 9:36 ` Pany
2020-10-19 17:40 ` Alan Stern
2020-10-20 12:03 ` M. Vefa Bicakci
2020-10-20 15:28 ` Alan Stern
2020-10-21 4:18 ` M. Vefa Bicakci
2020-10-21 11:53 ` Bastien Nocera
2020-10-21 12:02 ` Bastien Nocera
2020-10-21 12:29 ` Alan Stern
2020-10-21 12:31 ` Bastien Nocera
2020-10-21 13:01 ` Bastien Nocera
2020-10-21 13:08 ` M. Vefa Bicakci
2020-10-21 13:18 ` Bastien Nocera
2020-10-21 13:21 ` Bastien Nocera
2020-10-21 20:11 ` Alan Stern
2020-10-21 20:49 ` M. Vefa Bicakci
2020-10-21 20:49 ` M. Vefa Bicakci
2020-10-22 13:55 ` [PATCH 0/2] Patches to prevent re-probing all Apple USB devices on apple-mfi-fastcharge load M. Vefa Bicakci
2020-10-22 13:55 ` [PATCH 1/2] usbcore: Check both id_table and match() when both available M. Vefa Bicakci
2020-10-22 13:59 ` M. Vefa Bicakci
[not found] ` <CAHp75VeBgQ2ywLzU5PZEdfS+9M_niD0KoiEG=UMNH+4cPfsCNw@mail.gmail.com>
2020-10-23 12:51 ` M. Vefa Bicakci
2020-10-27 14:02 ` Bastien Nocera
2020-10-28 4:00 ` Pany
2020-10-29 3:33 ` M. Vefa Bicakci
2020-10-29 5:35 ` Pany [this message]
2020-10-22 13:55 ` [PATCH 2/2] USB: apple-mfi-fastcharge: don't probe unhandled devices M. Vefa Bicakci
2020-10-27 14:02 ` Bastien Nocera
2020-10-28 4:01 ` Pany
2020-10-21 3:17 ` Bug caused by 53965c79c2db (USB: Fix device driver race) Pany
2020-10-21 4:18 ` M. Vefa Bicakci
2020-10-21 5:19 ` Pany
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE3RAxsaUa=dEaSj7dVH1jtzGQpf1-4uMvDRxZnTpEBW+WpsoQ@mail.gmail.com' \
--to=pany@fedoraproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-usb@vger.kernel.org \
--cc=m.v.b@runbox.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.