From: Evan Green <evgreen@google.com>
To: Odelu Kukatla <okukatla@codeaurora.org>
Cc: Georgi Djakov <georgi.djakov@linaro.org>,
David Dai <daidavid1@codeaurora.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Andy Gross <agross@kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
linux-pm@vger.kernel.org, sboyd@kernel.org,
Lina Iyer <ilina@codeaurora.org>,
Sean Sweeney <seansw@qti.qualcomm.com>,
Alex Elder <elder@linaro.org>,
linux-arm-msm-owner@vger.kernel.org
Subject: Re: [v5, 2/3] interconnect: qcom: Add SC7180 interconnect provider driver
Date: Mon, 9 Mar 2020 10:33:45 -0700 [thread overview]
Message-ID: <CAE=gft5LE=_hBLbkWHDAQ6O9vrbfF=LtS7B=1tWWDE3euZov_g@mail.gmail.com> (raw)
In-Reply-To: <1583241493-21212-3-git-send-email-okukatla@codeaurora.org>
On Tue, Mar 3, 2020 at 5:18 AM Odelu Kukatla <okukatla@codeaurora.org> wrote:
>
> Add driver for the Qualcomm interconnect buses found in SC7180 based
> platforms. The topology consists of several NoCs that are controlled by
> a remote processor that collects the aggregated bandwidth for each
> master-slave pairs.
>
> Signed-off-by: Odelu Kukatla <okukatla@codeaurora.org>
> ---
> drivers/interconnect/qcom/Kconfig | 10 +
> drivers/interconnect/qcom/Makefile | 2 +
> drivers/interconnect/qcom/sc7180.c | 641 +++++++++++++++++++++++++++++++++++++
> drivers/interconnect/qcom/sc7180.h | 149 +++++++++
> 4 files changed, 802 insertions(+)
> create mode 100644 drivers/interconnect/qcom/sc7180.c
> create mode 100644 drivers/interconnect/qcom/sc7180.h
>
> diff --git a/drivers/interconnect/qcom/Kconfig b/drivers/interconnect/qcom/Kconfig
> index f6418a6..482c5be 100644
> --- a/drivers/interconnect/qcom/Kconfig
> +++ b/drivers/interconnect/qcom/Kconfig
> @@ -42,6 +42,16 @@ config INTERCONNECT_QCOM_RPMH
> depends on INTERCONNECT_QCOM || COMPILE_TEST
> depends on QCOM_COMMAND_DB
>
> +config INTERCONNECT_QCOM_SC7180
> + tristate "Qualcomm SC7180 interconnect driver"
> + depends on INTERCONNECT_QCOM
> + depends on (QCOM_RPMH && QCOM_COMMAND_DB && OF) || COMPILE_TEST
> + select INTERCONNECT_QCOM_RPMH
> + select INTERCONNECT_QCOM_BCM_VOTER
> + help
> + This is a driver for the Qualcomm Network-on-Chip on sc7180-based
> + platforms.
> +
> config INTERCONNECT_QCOM_SDM845
> tristate "Qualcomm SDM845 interconnect driver"
> depends on INTERCONNECT_QCOM
> diff --git a/drivers/interconnect/qcom/Makefile b/drivers/interconnect/qcom/Makefile
> index d591bb5..5325558 100644
> --- a/drivers/interconnect/qcom/Makefile
> +++ b/drivers/interconnect/qcom/Makefile
> @@ -5,6 +5,7 @@ qnoc-msm8916-objs := msm8916.o
> qnoc-msm8974-objs := msm8974.o
> qnoc-qcs404-objs := qcs404.o
> icc-rpmh-obj := icc-rpmh.o
> +qnoc-sc7180-objs := sc7180.o
> qnoc-sdm845-objs := sdm845.o
> icc-smd-rpm-objs := smd-rpm.o
>
> @@ -13,5 +14,6 @@ obj-$(CONFIG_INTERCONNECT_QCOM_MSM8916) += qnoc-msm8916.o
> obj-$(CONFIG_INTERCONNECT_QCOM_MSM8974) += qnoc-msm8974.o
> obj-$(CONFIG_INTERCONNECT_QCOM_QCS404) += qnoc-qcs404.o
> obj-$(CONFIG_INTERCONNECT_QCOM_RPMH) += icc-rpmh.o
> +obj-$(CONFIG_INTERCONNECT_QCOM_SC7180) += qnoc-sc7180.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SDM845) += qnoc-sdm845.o
> obj-$(CONFIG_INTERCONNECT_QCOM_SMD_RPM) += icc-smd-rpm.o
> diff --git a/drivers/interconnect/qcom/sc7180.c b/drivers/interconnect/qcom/sc7180.c
> new file mode 100644
> index 0000000..dcf493d
> --- /dev/null
> +++ b/drivers/interconnect/qcom/sc7180.c
> @@ -0,0 +1,641 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/*
> + * Copyright (c) 2020, The Linux Foundation. All rights reserved.
> + *
> + */
> +
> +#include <linux/device.h>
> +#include <linux/interconnect.h>
> +#include <linux/interconnect-provider.h>
> +#include <linux/module.h>
> +#include <linux/of_platform.h>
Nit: As Georgi mentioned in the previous review, you can remove this
an replace it with of_device.h. No need to spin for just that, though.
Reviewed-by: Evan Green <evgreen@chromium.org>
next prev parent reply other threads:[~2020-03-09 17:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 13:18 [v5, 0/3] Add SC7180 interconnect provider driver Odelu Kukatla
2020-03-03 13:18 ` [v5, 1/3] dt-bindings: interconnect: Add Qualcomm SC7180 DT bindings Odelu Kukatla
2020-03-03 13:18 ` [v5, 2/3] interconnect: qcom: Add SC7180 interconnect provider driver Odelu Kukatla
2020-03-09 17:33 ` Evan Green [this message]
2020-03-10 15:35 ` Georgi Djakov
2020-03-03 13:18 ` [v5, 3/3] arm64: dts: sc7180: Add interconnect provider DT nodes Odelu Kukatla
2020-03-04 16:30 ` Georgi Djakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAE=gft5LE=_hBLbkWHDAQ6O9vrbfF=LtS7B=1tWWDE3euZov_g@mail.gmail.com' \
--to=evgreen@google.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daidavid1@codeaurora.org \
--cc=elder@linaro.org \
--cc=georgi.djakov@linaro.org \
--cc=ilina@codeaurora.org \
--cc=linux-arm-msm-owner@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=okukatla@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=seansw@qti.qualcomm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.