From: Joel Fernandes <joel@joelfernandes.org>
To: paulmck@kernel.org
Cc: linux-kernel@vger.kernel.org,
Josh Triplett <josh@joshtriplett.org>,
Steven Rostedt <rostedt@goodmis.org>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Lai Jiangshan <jiangshanlai@gmail.com>,
Shuah Khan <shuah@kernel.org>,
rcu@vger.kernel.org, linux-kselftest@vger.kernel.org
Subject: Re: [PATCH] rcu/torture: Improve badness extraction from console logs
Date: Sat, 2 Sep 2023 20:10:13 -0400 [thread overview]
Message-ID: <CAEXW_YSukJ_SSvy731iF9WZ5N9cycHsfzdz+8MKA4Va+1+FW4A@mail.gmail.com> (raw)
In-Reply-To: <e0977773-de90-42bb-a67d-dc16d24764a3@paulmck-laptop>
On Sat, Sep 2, 2023 at 3:24 PM Paul E. McKenney <paulmck@kernel.org> wrote:
>
[...]
> > > Either way, what I don't want is many megabytes of splats from console.log
> > > duplicated into console.log.diags, especially in those (admittedly sad)
> > > cases where the console.log file is the largest file in the results
> > > directory. Are you really going to be reading carefully after (say)
> > > the fifth splat? ;-)
> >
> > I could limit it to just the first 5, with the existing unlimited
> > summary at the top.
>
> How about limiting the existing summary to (say) 10 lines? I do not
> recall every caring about more than that. The only reason that I did
> not ever limit it myself is that the summary is unlikely to be more than
> a few percent of the full console.log.
>
> > Let me know if that works or does not work for you. :-)
>
> I do believe that we might be converging. ;-)
Ok, so 10 lines of summary (similar to existing), and 10 detailed
splats below that :-). If that's not Ok, let me know. Otherwise I
will send the new patch soon. Thanks!
- Joel
next prev parent reply other threads:[~2023-09-03 0:10 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 1:22 [PATCH] rcu/torture: Improve badness extraction from console logs Joel Fernandes (Google)
2023-09-01 14:49 ` Paul E. McKenney
2023-09-01 18:04 ` Joel Fernandes
2023-09-02 13:53 ` Paul E. McKenney
2023-09-02 18:28 ` Joel Fernandes
2023-09-02 19:24 ` Paul E. McKenney
2023-09-03 0:10 ` Joel Fernandes [this message]
2023-09-03 1:38 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEXW_YSukJ_SSvy731iF9WZ5N9cycHsfzdz+8MKA4Va+1+FW4A@mail.gmail.com \
--to=joel@joelfernandes.org \
--cc=jiangshanlai@gmail.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=paulmck@kernel.org \
--cc=rcu@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.