All of lore.kernel.org
 help / color / mirror / Atom feed
From: Joel Fernandes <joel@joelfernandes.org>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-kernel@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	Uladzislau Rezki <urezki@gmail.com>,
	Lorenzo Stoakes <lstoakes@gmail.com>,
	Zhen Lei <thunder.leizhen@huaweicloud.com>,
	"Paul E . McKenney" <paulmck@kernel.org>,
	rcu@vger.kernel.org, Zqiang <qiang.zhang1211@gmail.com>,
	linux-mm@kvack.org
Subject: Re: [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug
Date: Wed, 30 Aug 2023 09:09:27 -0400	[thread overview]
Message-ID: <CAEXW_YTkejk872nJYTZ0HtMYLRswOjSPJyFz=HZjLKWUmy9GPQ@mail.gmail.com> (raw)
In-Reply-To: <ZO86ik6QWamW2u/j@infradead.org>

Hi Christoph,

On Wed, Aug 30, 2023 at 8:48 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> On Wed, Aug 30, 2023 at 11:03:59AM +0000, Joel Fernandes (Google) wrote:
> > It is unsafe to dump vmalloc area information when trying to do so from
> > some contexts. Add a safer trylock version of the same function to do a
> > best-effort VMA finding and use it from vmalloc_dump_obj().
>
> Seems like 2/2 to actually use this is missing?

1/2 itself uses it.

And then 2/2 is here which does additional improvement courtesy of Zqiang:
https://lore.kernel.org/all/20230830110402.386898-2-joel@joelfernandes.org/

I used git send-email with cc-cmd set to get_maintainer.pl script.

thanks,

 - Joel

      reply	other threads:[~2023-08-30 18:56 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-30 11:03 [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Joel Fernandes (Google)
2023-08-30 11:04 ` [PATCH 2/2] rcu: Dump vmalloc memory info safely Joel Fernandes (Google)
2023-08-30 12:08   ` Matthew Wilcox
2023-09-03  1:28   ` Andrew Morton
2023-09-03  2:03     ` Joel Fernandes
2023-09-03  2:05       ` Joel Fernandes
2023-08-30 12:07 ` [PATCH 1/2] mm/vmalloc: Add a safer version of find_vm_area() for debug Matthew Wilcox
2023-08-30 12:17   ` Joel Fernandes
2023-08-30 12:48 ` Christoph Hellwig
2023-08-30 13:09   ` Joel Fernandes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAEXW_YTkejk872nJYTZ0HtMYLRswOjSPJyFz=HZjLKWUmy9GPQ@mail.gmail.com' \
    --to=joel@joelfernandes.org \
    --cc=akpm@linux-foundation.org \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lstoakes@gmail.com \
    --cc=paulmck@kernel.org \
    --cc=qiang.zhang1211@gmail.com \
    --cc=rcu@vger.kernel.org \
    --cc=thunder.leizhen@huaweicloud.com \
    --cc=urezki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.