From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Dmitrii Banshchikov <me@ubique.spb.ru>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Martin Lau <kafai@fb.com>,
Song Liu <songliubraving@fb.com>, Yonghong Song <yhs@fb.com>,
john fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@chromium.org>, Andrey Ignatov <rdna@fb.com>
Subject: Re: [PATCH v3 bpf-next 4/4] selftests/bpf: Add unit tests for pointers in global functions
Date: Fri, 12 Feb 2021 13:15:19 -0800 [thread overview]
Message-ID: <CAEf4BzYrVCXDSHE=hcZaONnx47Spqu6vypc1qg=Aju5n5HDpHg@mail.gmail.com> (raw)
In-Reply-To: <20210212205642.620788-5-me@ubique.spb.ru>
On Fri, Feb 12, 2021 at 12:57 PM Dmitrii Banshchikov <me@ubique.spb.ru> wrote:
>
> test_global_func9 - check valid pointer's scenarios
> test_global_func10 - check that a smaller type cannot be passed as a
> larger one
> test_global_func11 - check that CTX pointer cannot be passed
> test_global_func12 - check access to a null pointer
> test_global_func13 - check access to an arbitrary pointer value
> test_global_func14 - check that an opaque pointer cannot be passed
> test_global_func15 - check that a variable has an unknown value after
> it was passed to a global function by pointer
> test_global_func16 - check access to uninitialized stack memory
>
> test_global_func_args - check read and write operations through a pointer
>
> Signed-off-by: Dmitrii Banshchikov <me@ubique.spb.ru>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andrii@kernel.org>
> .../bpf/prog_tests/global_func_args.c | 60 ++++++++
> .../bpf/prog_tests/test_global_funcs.c | 8 ++
> .../selftests/bpf/progs/test_global_func10.c | 29 ++++
> .../selftests/bpf/progs/test_global_func11.c | 19 +++
> .../selftests/bpf/progs/test_global_func12.c | 21 +++
> .../selftests/bpf/progs/test_global_func13.c | 24 ++++
> .../selftests/bpf/progs/test_global_func14.c | 21 +++
> .../selftests/bpf/progs/test_global_func15.c | 22 +++
> .../selftests/bpf/progs/test_global_func16.c | 22 +++
> .../selftests/bpf/progs/test_global_func9.c | 132 ++++++++++++++++++
> .../bpf/progs/test_global_func_args.c | 91 ++++++++++++
> 11 files changed, 449 insertions(+)
> create mode 100644 tools/testing/selftests/bpf/prog_tests/global_func_args.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func10.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func11.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func12.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func13.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func14.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func15.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func16.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func9.c
> create mode 100644 tools/testing/selftests/bpf/progs/test_global_func_args.c
>
[...]
next prev parent reply other threads:[~2021-02-12 21:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-12 20:56 [PATCH v3 bpf-next 0/4] Add support of pointer to struct in global functions Dmitrii Banshchikov
2021-02-12 20:56 ` [PATCH v3 bpf-next 1/4] bpf: Rename bpf_reg_state variables Dmitrii Banshchikov
2021-02-12 21:11 ` Andrii Nakryiko
2021-02-12 20:56 ` [PATCH v3 bpf-next 2/4] bpf: Extract nullable reg type conversion into a helper function Dmitrii Banshchikov
2021-02-12 21:12 ` Andrii Nakryiko
2021-02-12 20:56 ` [PATCH v3 bpf-next 3/4] bpf: Support pointers in global func args Dmitrii Banshchikov
2021-02-12 21:14 ` Andrii Nakryiko
2021-02-13 2:09 ` Alexei Starovoitov
2021-02-15 6:25 ` Dmitrii Banshchikov
2021-02-12 20:56 ` [PATCH v3 bpf-next 4/4] selftests/bpf: Add unit tests for pointers in global functions Dmitrii Banshchikov
2021-02-12 21:15 ` Andrii Nakryiko [this message]
2021-02-23 6:43 ` Andrii Nakryiko
2021-02-23 8:22 ` [PATCH] selftests/bpf: Fix a compiler warning in global func test Dmitrii Banshchikov
2021-02-24 15:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzYrVCXDSHE=hcZaONnx47Spqu6vypc1qg=Aju5n5HDpHg@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=john.fastabend@gmail.com \
--cc=kafai@fb.com \
--cc=kpsingh@chromium.org \
--cc=me@ubique.spb.ru \
--cc=rdna@fb.com \
--cc=songliubraving@fb.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.