From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Hengqi Chen <hengqi.chen@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>, Yonghong Song <yhs@fb.com>,
john fastabend <john.fastabend@gmail.com>,
Jiri Olsa <jolsa@kernel.org>, Yaniv Agman <yanivagman@gmail.com>
Subject: Re: [PATCH bpf-next v4 0/2] bpf: expand bpf_d_path helper allowlist
Date: Thu, 29 Jul 2021 14:44:46 -0700 [thread overview]
Message-ID: <CAEf4BzZ-w9QES5AgNLt61crA8S1SZP3OoFM+d6eSbrphSiuJHQ@mail.gmail.com> (raw)
In-Reply-To: <20210726141013.2239765-1-hengqi.chen@gmail.com>
On Mon, Jul 26, 2021 at 7:10 AM Hengqi Chen <hengqi.chen@gmail.com> wrote:
>
> This patch set adds more functions to bpf_d_path allowlist.
>
> Patch 1 is prep work which updates resolve_btfids to emit warnings
> on missing symbols instead of aborting kernel build process.
>
> Patch 2 expands bpf_d_path allowlist.
>
> Changes since v3: [3]
> - Addressed Yonghong's comments. Sort allowlist and add security_bprm_*
>
> Changes since v2: [2]
> - Andrii suggested that we should first address an issue of .BTF_ids
> before adding more symbols to .BTF_ids. Fixed that.
> - Yaniv proposed adding security_sb_mount and security_bprm_check.
> Added them.
>
> Changes since v1: [1]
> - Alexei and Yonghong suggested that bpf_d_path helper could also
> apply to vfs_* and security_file_* kernel functions. Added them.
>
> [1] https://lore.kernel.org/bpf/20210712162424.2034006-1-hengqi.chen@gmail.com/
> [2] https://lore.kernel.org/bpf/20210719151753.399227-1-hengqi.chen@gmail.com/
> [3] https://lore.kernel.org/bpf/20210725141814.2000828-3-hengqi.chen@gmail.com/
>
I've applied the first patch to bpf-next. I'd like some more eyes on
patch #2, so I'm leaving it up for review by others for a bit longer.
> Hengqi Chen (2):
> tools/resolve_btfids: emit warnings and patch zero id for missing
> symbols
> bpf: expose bpf_d_path helper to vfs_* and security_* functions
>
> kernel/trace/bpf_trace.c | 60 ++++++++++++++++++++++++++++++---
> tools/bpf/resolve_btfids/main.c | 13 +++----
> 2 files changed, 63 insertions(+), 10 deletions(-)
>
> --
> 2.25.1
>
prev parent reply other threads:[~2021-07-29 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-26 14:10 [PATCH bpf-next v4 0/2] bpf: expand bpf_d_path helper allowlist Hengqi Chen
2021-07-26 14:10 ` [PATCH bpf-next v4 1/2] tools/resolve_btfids: emit warnings and patch zero id for missing symbols Hengqi Chen
2021-07-26 14:10 ` [PATCH bpf-next v4 2/2] bpf: expose bpf_d_path helper to vfs_* and security_* functions Hengqi Chen
2021-07-29 21:44 ` Andrii Nakryiko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzZ-w9QES5AgNLt61crA8S1SZP3OoFM+d6eSbrphSiuJHQ@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=hengqi.chen@gmail.com \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=yanivagman@gmail.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.