All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: David Verbeiren <david.verbeiren@tessares.net>
Cc: bpf <bpf@vger.kernel.org>, Networking <netdev@vger.kernel.org>,
	Matthieu Baerts <matthieu.baerts@tessares.net>
Subject: Re: [PATCH bpf v2] bpf: zero-fill re-used per-cpu map element
Date: Thu, 29 Oct 2020 15:40:20 -0700	[thread overview]
Message-ID: <CAEf4BzZBn9HWhTeyaOLXYwJtdandx44a8oJLjBunFUgjoN5Udw@mail.gmail.com> (raw)
In-Reply-To: <CAHzPrnEfDLZ6McM+OMBMPiJ1AT9JZta1eognnnowbtT9_pHGMw@mail.gmail.com>

On Thu, Oct 29, 2020 at 7:44 AM David Verbeiren
<david.verbeiren@tessares.net> wrote:
>
> On Tue, Oct 27, 2020 at 11:55 PM Andrii Nakryiko
> <andrii.nakryiko@gmail.com> wrote:
> > Looks good, but would be good to have a unit test (see below). Maybe
> > in a follow up.
>
> Here is the associated new selftest, implementing the sequence you
> proposed (thanks for that!), and also one for LRU case:
> https://lore.kernel.org/bpf/20201029111730.6881-1-david.verbeiren@tessares.net/
>
> I hope I did it in the "right" framework of the day.

You did it in a very laborious and hard way, which will be harder to
maintain, unfortunately. But it should be trivial to simplify it with
skeleton. It's probably better to combine the selftest patch with the
kernel fix in this patch and send it as v2?

  reply	other threads:[~2020-10-29 22:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23 12:37 [PATCH bpf] bpf: zero-fill re-used per-cpu map element David Verbeiren
2020-10-26 22:47 ` Andrii Nakryiko
2020-10-27 14:48   ` David Verbeiren
2020-10-27 22:13 ` [PATCH bpf v2] " David Verbeiren
2020-10-27 22:55   ` Andrii Nakryiko
2020-10-29 14:44     ` David Verbeiren
2020-10-29 22:40       ` Andrii Nakryiko [this message]
2020-11-03 15:47   ` [PATCH bpf v3] " David Verbeiren
2020-11-03 18:19     ` Andrii Nakryiko
2020-11-04 11:23     ` [PATCH bpf v4] " David Verbeiren
2020-11-04 20:45       ` Andrii Nakryiko
2020-11-06  4:10       ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAEf4BzZBn9HWhTeyaOLXYwJtdandx44a8oJLjBunFUgjoN5Udw@mail.gmail.com \
    --to=andrii.nakryiko@gmail.com \
    --cc=bpf@vger.kernel.org \
    --cc=david.verbeiren@tessares.net \
    --cc=matthieu.baerts@tessares.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.