From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Jesper Dangaard Brouer <brouer@redhat.com>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
Daniel Borkmann <borkmann@iogearbox.net>,
Alexei Starovoitov <alexei.starovoitov@gmail.com>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH bpf-next] bpf: fix too large copy from user in bpf_test_init
Date: Mon, 18 May 2020 17:15:39 -0700 [thread overview]
Message-ID: <CAEf4BzZJ4dHHtWK-Kfiy2RRNsoK=3t8c94x_jxs6SDRVpcS-HA@mail.gmail.com> (raw)
In-Reply-To: <158980712729.256597.6115007718472928659.stgit@firesoul>
On Mon, May 18, 2020 at 6:08 AM Jesper Dangaard Brouer
<brouer@redhat.com> wrote:
>
> Commit bc56c919fce7 ("bpf: Add xdp.frame_sz in bpf_prog_test_run_xdp().")
> recently changed bpf_prog_test_run_xdp() to use larger frames for XDP in
> order to test tail growing frames (via bpf_xdp_adjust_tail) and to have
> memory backing frame better resemble drivers.
>
> The commit contains a bug, as it tries to copy the max data size from
> userspace, instead of the size provided by userspace. This cause XDP
> unit tests to fail sporadically with EFAULT, an unfortunate behavior.
> The fix is to only copy the size specified by userspace.
>
> Fixes: bc56c919fce7 ("bpf: Add xdp.frame_sz in bpf_prog_test_run_xdp().")
> Signed-off-by: Jesper Dangaard Brouer <brouer@redhat.com>
> ---
LGTM.
Acked-by: Andrii Nakryiko <andriin@fb.com>
> net/bpf/test_run.c | 8 +++++---
> 1 file changed, 5 insertions(+), 3 deletions(-)
>
[...]
next prev parent reply other threads:[~2020-05-19 0:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 13:05 [PATCH bpf-next] bpf: fix too large copy from user in bpf_test_init Jesper Dangaard Brouer
2020-05-19 0:15 ` Andrii Nakryiko [this message]
2020-05-19 17:22 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4BzZJ4dHHtWK-Kfiy2RRNsoK=3t8c94x_jxs6SDRVpcS-HA@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=borkmann@iogearbox.net \
--cc=bpf@vger.kernel.org \
--cc=brouer@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.