From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: Andrii Nakryiko <andrii@kernel.org>, bpf <bpf@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next] libbpf: fix non-C89 loop variable declaration in gen_loader.c
Date: Sat, 6 Nov 2021 12:56:19 -0700 [thread overview]
Message-ID: <CAEf4BzaehmbFQ50tZrZYtC+cTe+XTPBs2KBEXsjnmsSHWBYoUg@mail.gmail.com> (raw)
In-Reply-To: <CAADnVQJ6REFCJZYCLzk0NNqo5p9C5KpOmko9REaF1KYkBEaa9w@mail.gmail.com>
On Sat, Nov 6, 2021 at 9:38 AM Alexei Starovoitov
<alexei.starovoitov@gmail.com> wrote:
>
> On Fri, Nov 5, 2021 at 12:11 PM Andrii Nakryiko <andrii@kernel.org> wrote:
> >
> > Fix the `int i` declaration inside the for statement. This is non-C89
> > compliant. See [0] for user report breaking BCC build.
> >
> > [0] https://github.com/libbpf/libbpf/issues/403
>
> I'd prefer to fix bcc and/or its derivatives instead.
> It's year 2021.
Fixing BCC and derivatives is a separate topic. This is the only
instance of non-C89 compliant for() loop in libbpf and I'd prefer to
fix it at the very least for style consistency.
next prev parent reply other threads:[~2021-11-06 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 19:10 [PATCH bpf-next] libbpf: fix non-C89 loop variable declaration in gen_loader.c Andrii Nakryiko
2021-11-05 20:40 ` Kumar Kartikeya Dwivedi
2021-11-05 21:49 ` Andrii Nakryiko
2021-11-05 22:04 ` Kumar Kartikeya Dwivedi
2021-11-05 22:20 ` Andrii Nakryiko
2021-11-05 22:26 ` Kumar Kartikeya Dwivedi
2021-11-06 16:37 ` Alexei Starovoitov
2021-11-06 19:56 ` Andrii Nakryiko [this message]
2021-11-06 23:18 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEf4BzaehmbFQ50tZrZYtC+cTe+XTPBs2KBEXsjnmsSHWBYoUg@mail.gmail.com \
--to=andrii.nakryiko@gmail.com \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=kernel-team@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.