From: Andrii Nakryiko <andrii.nakryiko@gmail.com>
To: Xu Kuohai <xukuohai@huawei.com>
Cc: bpf@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, netdev@vger.kernel.org,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
Andrii Nakryiko <andrii@kernel.org>,
Martin KaFai Lau <martin.lau@linux.dev>,
Song Liu <song@kernel.org>, Yonghong Song <yhs@fb.com>,
John Fastabend <john.fastabend@gmail.com>,
KP Singh <kpsingh@kernel.org>,
Stanislav Fomichev <sdf@google.com>, Hao Luo <haoluo@google.com>,
Jiri Olsa <jolsa@kernel.org>, Mykola Lysenko <mykolal@fb.com>,
Shuah Khan <shuah@kernel.org>,
"David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Jesper Dangaard Brouer <hawk@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Alan Maguire <alan.maguire@oracle.com>,
Delyan Kratunov <delyank@fb.com>,
Lorenzo Bianconi <lorenzo@kernel.org>
Subject: Re: [PATCH bpf v3 0/6] Fix bugs found by ASAN when running selftests
Date: Mon, 10 Oct 2022 18:37:00 -0700 [thread overview]
Message-ID: <CAEf4Bzbt1_J=bzsSmO-xX=Ubi9UeGj8swQT7c1pZt_ay1npZhw@mail.gmail.com> (raw)
In-Reply-To: <20221010142553.776550-1-xukuohai@huawei.com>
On Mon, Oct 10, 2022 at 7:08 AM Xu Kuohai <xukuohai@huawei.com> wrote:
>
Thanks for the fixes! I left a few comments in a few patches, please
address those. But also
please provide a commit message, even if a single line one. Kernel
style dictates that the commit message shouldn't be empty.
And I think none of these fixes are critical enough to go to bpf tree,
please target bpf-next for next revision. Thanks.
> v3:
> - Fix error failure of case test_xdp_adjust_tail_grow exposed by this series
>
> v2: https://lore.kernel.org/bpf/20221010070454.577433-1-xukuohai@huaweicloud.com
> - Rebase and fix conflict
>
> v1: https://lore.kernel.org/bpf/20221009131830.395569-1-xukuohai@huaweicloud.com
>
> Xu Kuohai (6):
> libbpf: Fix use-after-free in btf_dump_name_dups
> libbpf: Fix memory leak in parse_usdt_arg()
> selftests/bpf: Fix memory leak caused by not destroying skeleton
> selftest/bpf: Fix memory leak in kprobe_multi_test
> selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow
> selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c
>
> tools/lib/bpf/btf_dump.c | 47 +++++++++++----
> tools/lib/bpf/usdt.c | 59 +++++++++++--------
> .../bpf/prog_tests/kprobe_multi_test.c | 17 +++---
> .../selftests/bpf/prog_tests/map_kptr.c | 3 +-
> .../selftests/bpf/prog_tests/tracing_struct.c | 3 +-
> .../bpf/prog_tests/xdp_adjust_tail.c | 7 ++-
> 6 files changed, 86 insertions(+), 50 deletions(-)
>
> --
> 2.30.2
>
next prev parent reply other threads:[~2022-10-11 1:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-10 14:25 [PATCH bpf v3 0/6] Fix bugs found by ASAN when running selftests Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 1/6] libbpf: Fix use-after-free in btf_dump_name_dups Xu Kuohai
2022-10-11 1:32 ` Andrii Nakryiko
2022-10-11 6:25 ` Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 2/6] libbpf: Fix memory leak in parse_usdt_arg() Xu Kuohai
2022-10-11 1:34 ` Andrii Nakryiko
2022-10-11 6:26 ` Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 3/6] selftests/bpf: Fix memory leak caused by not destroying skeleton Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 4/6] selftest/bpf: Fix memory leak in kprobe_multi_test Xu Kuohai
2022-10-11 1:34 ` Andrii Nakryiko
2022-10-11 6:26 ` Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 5/6] selftests/bpf: Fix error failure of case test_xdp_adjust_tail_grow Xu Kuohai
2022-10-10 14:25 ` [PATCH bpf v3 6/6] selftest/bpf: Fix error usage of ASSERT_OK in xdp_adjust_tail.c Xu Kuohai
2022-10-11 1:37 ` Andrii Nakryiko [this message]
2022-10-11 6:30 ` [PATCH bpf v3 0/6] Fix bugs found by ASAN when running selftests Xu Kuohai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAEf4Bzbt1_J=bzsSmO-xX=Ubi9UeGj8swQT7c1pZt_ay1npZhw@mail.gmail.com' \
--to=andrii.nakryiko@gmail.com \
--cc=alan.maguire@oracle.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=delyank@fb.com \
--cc=haoluo@google.com \
--cc=hawk@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=martin.lau@linux.dev \
--cc=memxor@gmail.com \
--cc=mykolal@fb.com \
--cc=netdev@vger.kernel.org \
--cc=sdf@google.com \
--cc=shuah@kernel.org \
--cc=song@kernel.org \
--cc=xukuohai@huawei.com \
--cc=yhs@fb.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.