From: Stephen Smalley <stephen.smalley.work@gmail.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>
Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com,
paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com,
eparis@parisplace.org, xieyongji@bytedance.com,
virtualization@lists.linux-foundation.org,
linux-kernel@vger.kernel.org,
linux-security-module@vger.kernel.org, selinux@vger.kernel.org,
david.marchand@redhat.com, lulu@redhat.com,
casey@schaufler-ca.com
Subject: Re: [PATCH v5 4/4] vduse: Add LSM hook to check Virtio device type
Date: Mon, 18 Dec 2023 12:21:18 -0500 [thread overview]
Message-ID: <CAEjxPJ6zMbM5jPkLC_wDHsXWXofWcDntHRDWQTS6hojECVJPTw@mail.gmail.com> (raw)
In-Reply-To: <20231212131712.1816324-5-maxime.coquelin@redhat.com>
On Tue, Dec 12, 2023 at 8:17 AM Maxime Coquelin
<maxime.coquelin@redhat.com> wrote:
>
> This patch introduces a LSM hook for devices creation,
> destruction (ioctl()) and opening (open()) operations,
> checking the application is allowed to perform these
> operations for the Virtio device type.
Can you explain why the existing LSM hooks and SELinux implementation
are not sufficient? We already control the ability to open device
nodes via selinux_inode_permission() and selinux_file_open(), and can
support fine-grained per-cmd ioctl checking via selinux_file_ioctl().
And it should already be possible to label these nodes distinctly
through existing mechanisms (file_contexts if udev-created/labeled,
genfs_contexts if kernel-created). What exactly can't you do today
that this hook enables?
next prev parent reply other threads:[~2023-12-18 17:21 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-12 13:17 [PATCH v5 0/4] vduse: add support for networking devices Maxime Coquelin
2023-12-12 13:17 ` [PATCH v5 1/4] vduse: validate block features only with block devices Maxime Coquelin
2023-12-12 13:17 ` [PATCH v5 2/4] vduse: Temporarily disable control queue features Maxime Coquelin
2023-12-13 4:52 ` Jason Wang
2023-12-13 11:23 ` Maxime Coquelin
2023-12-18 2:50 ` Jason Wang
2023-12-18 9:21 ` Maxime Coquelin
2023-12-20 3:50 ` Jason Wang
2023-12-12 13:17 ` [PATCH v5 3/4] vduse: enable Virtio-net device type Maxime Coquelin
2023-12-12 13:17 ` [PATCH v5 4/4] vduse: Add LSM hook to check Virtio " Maxime Coquelin
2023-12-12 16:33 ` Casey Schaufler
2023-12-12 17:59 ` Michael S. Tsirkin
2023-12-12 22:55 ` Casey Schaufler
2023-12-16 4:18 ` Serge E. Hallyn
2023-12-18 17:21 ` Stephen Smalley [this message]
2023-12-18 17:33 ` Stephen Smalley
2024-01-04 10:14 ` Maxime Coquelin
2023-12-19 18:20 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAEjxPJ6zMbM5jPkLC_wDHsXWXofWcDntHRDWQTS6hojECVJPTw@mail.gmail.com \
--to=stephen.smalley.work@gmail.com \
--cc=casey@schaufler-ca.com \
--cc=david.marchand@redhat.com \
--cc=eparis@parisplace.org \
--cc=jasowang@redhat.com \
--cc=jmorris@namei.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=lulu@redhat.com \
--cc=maxime.coquelin@redhat.com \
--cc=mst@redhat.com \
--cc=paul@paul-moore.com \
--cc=selinux@vger.kernel.org \
--cc=serge@hallyn.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=xieyongji@bytedance.com \
--cc=xuanzhuo@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.