Re: [PATCH v9 1/5] configfs: Allow dynamic group creation

From: Daniel Baluta <daniel.baluta@intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Daniel Baluta <daniel.baluta@intel.com>,
	Jonathan Cameron <jic23@kernel.org>,
	Joel Becker <jlbec@evilplan.org>,
	"linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org,
	Lars-Peter Clausen <lars@metafoo.de>,
	Hartmut Knaack <knaack.h@gmx.de>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	"octavian.purdila@intel.com" <octavian.purdila@intel.com>,
	Paul Bolle <pebolle@tiscali.nl>,
	patrick.porlan@intel.com, Adriana Reus <adriana.reus@intel.com>,
	constantin.musca@intel.com, marten@intuitiveaerial.com,
	Cristina Georgiana Opriceana <cristina.opriceana@gmail.com>,
	Peter Meerwald <pmeerw@pmeerw.net>,
	viro@zeniv.linux.org.uk,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v9 1/5] configfs: Allow dynamic group creation
Date: Fri, 23 Oct 2015 16:08:41 +0300	[thread overview]
Message-ID: <CAEnQRZCMoa0PMhb4CGu3NL5vNeZg_viuHWndtm_Mpxi-kC115A@mail.gmail.com> (raw)
In-Reply-To: <20151023124812.GA4588@lst.de>

On Fri, Oct 23, 2015 at 3:48 PM, Christoph Hellwig <hch@lst.de> wrote:
> Hi Daniel,
>
> all these functions look great, but can you also move your new
> iio_sw_trigger_type_configfs_register/unregister functions to the
> core code as those are the wrappers that everyone would have to write,
> e.g. something like:
>
> int configfs_register_default_group(struct config_group *parent_group,
>                 const char *name, struct config_item_type *item_type)
> {
>         struct config_group *group;
>
>         group = kzalloc(sizeof(*group), GFP_KERNEL);
>         if (!group)
>                 return -ENOMEM;
>         config_group_init_type_name(group, name, item_type);
>
>         ret = configfs_register_group(parent_group, group);
>         if (ret)
>                 kfree(group);
>         return ret;
> }
>
> and the same on the unregister side?
Yes, this is a good idea. Will do!
>
> With that:
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>

thanks,
Daniel.