From: Micka <mickamusset@gmail.com>
To: Mark Brown <broonie@kernel.org>, anish kumar <yesanishhere@gmail.com>
Cc: alsa-devel@alsa-project.org, lgirdwood@gmail.com
Subject: Re: [PATCH] ASoC: Add max98371 codec driver
Date: Mon, 21 Mar 2016 15:29:00 +0000 [thread overview]
Message-ID: <CAF+MRtkm+OHQHwW4cTihSV5MOnJWiq4XfjoxghYN7eq05e0pWw@mail.gmail.com> (raw)
In-Reply-To: <20160321145642.GV2566@sirena.org.uk>
Hi Mark,
Could you tell me how do you control this device/codec with Linux ? What is
the command ?
Thank you !
Le lun. 21 mars 2016 à 16:03, Mark Brown <broonie@kernel.org> a écrit :
> On Sun, Mar 20, 2016 at 06:59:02PM -0700, anish kumar wrote:
>
> This looks mostly good, a few small things:
>
> > +static const char *const voltage_level_text[] = {
> > + "9.5dB", "10.5dB", "11.5dB", "11.5dB", "12.5dB",
> > + "13.5dB", "14.5dB", "15.5dB", "16.5dB", "17.5dB",
> > + "18.5dB", "19.5dB", "20.5dB"
> > +};
>
> Volume controls should be done with TLV data not enums.
>
> > +static const struct snd_kcontrol_new max98371_snd_controls[] = {
> > + SOC_SINGLE_TLV("Speaker Gain", MAX98371_GAIN,
> > + MAX98371_GAIN_SHIFT, (1<<MAX98371_GAIN_WIDTH)-1, 0,
> > + max98371_gain_tlv),
>
> Volume controls should end with Volume.
>
> > +static int max98371_probe(struct snd_soc_codec *codec)
> > +{
> > + struct max98371_priv *max98371 = snd_soc_codec_get_drvdata(codec);
> > +
> > + max98371->codec = codec;
> > + return 0;
> > +}
>
> Do we ever actually use this?
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-03-21 15:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-21 1:59 [PATCH] ASoC: Add max98371 codec driver anish kumar
2016-03-21 14:56 ` Mark Brown
2016-03-21 15:29 ` Micka [this message]
2016-03-21 15:56 ` Mark Brown
2016-03-21 16:41 ` Micka
2016-03-21 17:05 ` Mark Brown
2016-03-23 12:45 ` Micka
2016-03-23 16:23 ` Amish Kumar
2016-03-24 10:49 ` Micka
2016-03-24 11:05 ` Mark Brown
2016-03-24 11:19 ` Micka
2016-03-24 11:21 ` Mark Brown
2016-03-22 6:53 anish kumar
2016-03-28 19:13 ` Mark Brown
2016-04-07 19:34 ` anish kumar
2016-04-08 3:09 ` Lars-Peter Clausen
2016-04-08 20:04 ` anish kumar
2016-04-10 18:04 ` Mark Brown
2016-04-13 20:20 anish kumar
2016-04-18 16:47 ` Mark Brown
2016-04-18 20:20 ` anish kumar
2016-04-19 9:46 ` Mark Brown
2016-04-20 18:14 ` anish kumar
2016-04-22 15:31 ` Mark Brown
2016-04-26 18:16 ` anish kumar
2016-04-27 16:42 ` Mark Brown
2016-04-27 22:39 anish kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAF+MRtkm+OHQHwW4cTihSV5MOnJWiq4XfjoxghYN7eq05e0pWw@mail.gmail.com \
--to=mickamusset@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=yesanishhere@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.