Re: RadosGW crashing on copy for one specific object

From: Sylvain Munaut <s.munaut@whatever-company.com>
To: Yehuda Sadeh <yehuda@redhat.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>
Subject: Re: RadosGW crashing on copy for one specific object
Date: Mon, 25 Aug 2014 11:00:46 +0200	[thread overview]
Message-ID: <CAF6-1L60V1HzCKv1FR_honU5QxYBVZx6gb9AUQrOL+H-N7wwSw@mail.gmail.com> (raw)
In-Reply-To: <CABBk=J8S_fkBMORDy9RbYLh6HWi+-EzyZefBNPmnBRWNuPOHAg@mail.gmail.com>

Hi Yehuda,

> diff --git a/src/rgw/rgw_rados.h b/src/rgw/rgw_rados.h
> index ed8f02d..0042df2 100644
> --- a/src/rgw/rgw_rados.h
> +++ b/src/rgw/rgw_rados.h
> @@ -306,6 +306,11 @@ public:
>
>    bool has_tail() {
>      if (explicit_objs) {
> +      if (objs.size() == 1) {
> +        map<uint64_t, RGWObjManifestPart>::iterator iter = objs.begin();
> +        rgw_obj& obj = iter->second.loc;
> +        return head_obj.object != obj.object;
> +      }
>        return (objs.size() >= 2);
>      }
>      return (obj_size > head_size);
>

I confirm that this fixes the issue.

I was able to copy the key and read the resulting copied key.

Cheers,

     Sylvain