From: Peter Maydell <peter.maydell@linaro.org>
To: Richard Henderson <richard.henderson@linaro.org>
Cc: qemu-arm <qemu-arm@nongnu.org>, QEMU Developers <qemu-devel@nongnu.org>
Subject: Re: [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state
Date: Tue, 22 Oct 2019 13:47:22 +0100 [thread overview]
Message-ID: <CAFEAcA-MyKoA63UF6DYQ6J-dKihYn9iyG09eFCgWT8j4OqsQnw@mail.gmail.com> (raw)
In-Reply-To: <20191018174431.1784-1-richard.henderson@linaro.org>
On Fri, 18 Oct 2019 at 18:44, Richard Henderson
<richard.henderson@linaro.org> wrote:
>
> Changes since v7:
> * Rebuild hflags for all successful nvic writes (Peter).
> * Rebuild hflags for Xscale sctlr writes (Peter).
>
> Changes since v6:
> * Regen hflags in two more places for m-profile (patch 19).
>
> Changes since v5:
> * Fix the debug assertion ifdef in the final patch.
> * Add more calls to arm_rebuild_hflags: CPSR and M-profile
> These become two new patches, 18 & 19.
> * Update some comments per review. (Alex)
>
> Changes since v4:
> * Split patch 1 into 15 smaller patches.
> * Cache the new DEBUG_TARGET_EL field.
> * Split out m-profile hflags separately from a-profile 32-bit.
> * Move around non-cached tb flags as well, avoiding repetitive
> checks for m-profile or other mutually exclusive conditions.
>
> I haven't officially re-run the performance test quoted in the
> last patch, but I have eyeballed "perf top", and have dug into
> the compiled code a bit, which resulted in a few of the new
> cleanup patches (e.g. cs_base, arm_mmu_idx_el, and
> arm_cpu_data_is_big_endian).
> ...
>
>
> r~
Applied to target-arm.next, thanks.
-- PMM
next prev parent reply other threads:[~2019-10-22 12:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-18 17:44 [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 01/22] target/arm: Split out rebuild_hflags_common Richard Henderson
2019-10-18 17:44 ` [PATCH v8 02/22] target/arm: Split out rebuild_hflags_a64 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 03/22] target/arm: Split out rebuild_hflags_common_32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 04/22] target/arm: Split arm_cpu_data_is_big_endian Richard Henderson
2019-10-18 17:44 ` [PATCH v8 05/22] target/arm: Split out rebuild_hflags_m32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 06/22] target/arm: Reduce tests vs M-profile in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 07/22] target/arm: Split out rebuild_hflags_a32 Richard Henderson
2019-10-18 17:44 ` [PATCH v8 08/22] target/arm: Split out rebuild_hflags_aprofile Richard Henderson
2019-10-18 17:44 ` [PATCH v8 09/22] target/arm: Hoist XSCALE_CPAR, VECLEN, VECSTRIDE in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 10/22] target/arm: Simplify set of PSTATE_SS " Richard Henderson
2019-10-18 17:44 ` [PATCH v8 11/22] target/arm: Hoist computation of TBFLAG_A32.VFPEN Richard Henderson
2019-10-18 17:44 ` [PATCH v8 12/22] target/arm: Add arm_rebuild_hflags Richard Henderson
2019-10-18 17:44 ` [PATCH v8 13/22] target/arm: Split out arm_mmu_idx_el Richard Henderson
2019-10-18 17:44 ` [PATCH v8 14/22] target/arm: Hoist store to cs_base in cpu_get_tb_cpu_state Richard Henderson
2019-10-18 17:44 ` [PATCH v8 15/22] target/arm: Add HELPER(rebuild_hflags_{a32, a64, m32}) Richard Henderson
2019-10-18 17:44 ` [PATCH v8 16/22] target/arm: Rebuild hflags at EL changes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 17/22] target/arm: Rebuild hflags at MSR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 18/22] target/arm: Rebuild hflags at CPSR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 19/22] target/arm: Rebuild hflags at Xscale SCTLR writes Richard Henderson
2019-10-18 17:44 ` [PATCH v8 20/22] target/arm: Rebuild hflags for M-profile Richard Henderson
2019-10-18 17:44 ` [PATCH v8 21/22] target/arm: Rebuild hflags for M-profile NVIC Richard Henderson
2019-10-18 17:44 ` [PATCH v8 22/22] target/arm: Rely on hflags correct in cpu_get_tb_cpu_state Richard Henderson
2019-10-22 12:47 ` Peter Maydell [this message]
2019-10-22 15:38 ` [PATCH v8 00/22] target/arm: Reduce overhead of cpu_get_tb_cpu_state Peter Maydell
2019-10-23 14:49 ` Richard Henderson
2019-10-23 15:17 ` Alex Bennée
2019-10-23 16:13 ` Richard Henderson
2019-10-23 18:06 ` Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAFEAcA-MyKoA63UF6DYQ6J-dKihYn9iyG09eFCgWT8j4OqsQnw@mail.gmail.com \
--to=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.