From: Peter Maydell <peter.maydell@linaro.org>
To: Gan Qixin <ganqixin@huawei.com>
Cc: zhanghailiang <zhang.zhanghailiang@huawei.com>,
QEMU Trivial <qemu-trivial@nongnu.org>,
QEMU Developers <qemu-devel@nongnu.org>,
Euler Robot <euler.robot@huawei.com>,
"Chenqun \(kuhn\)" <kuhn.chenqun@huawei.com>,
David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH v3 2/2] misc/mos6522: Use timer_free() in the finalize function to avoid memleak
Date: Tue, 12 Jan 2021 16:42:41 +0000 [thread overview]
Message-ID: <CAFEAcA-Wh97xhmyjjJoD9HKiAhHq7SzuPjUoLWg=j4BPtHmWUw@mail.gmail.com> (raw)
In-Reply-To: <20210112112705.380534-3-ganqixin@huawei.com>
On Tue, 12 Jan 2021 at 11:29, Gan Qixin <ganqixin@huawei.com> wrote:
>
> When running device-introspect-test, a memory leak occurred in the mos6522_init
> function, this patch use timer_free() in the finalize function to fix it.
>
> ASAN shows memory leak stack:
>
> Direct leak of 96 byte(s) in 2 object(s) allocated from:
> #0 0xfffd5fe9e1f0 in __interceptor_calloc (/lib64/libasan.so.5+0xee1f0)
> #1 0xfffd5f7b6800 in g_malloc0 (/lib64/libglib-2.0.so.0+0x56800)
> #2 0xaaae50303d0c in timer_new_full qemu/include/qemu/timer.h:523
> #3 0xaaae50303d0c in timer_new qemu/include/qemu/timer.h:544
> #4 0xaaae50303d0c in timer_new_ns qemu/include/qemu/timer.h:562
> #5 0xaaae50303d0c in mos6522_init qemu/hw/misc/mos6522.c:490
> #6 0xaaae50b77d70 in object_init_with_type qemu/qom/object.c:371
> #7 0xaaae50b7ae84 in object_initialize_with_type qemu/qom/object.c:515
> #8 0xaaae50b7b0f8 in object_new_with_type qemu/qom/object.c:729
> #9 0xaaae50bb6d58 in qmp_device_list_properties qemu/qom/qom-qmp-cmds.c:153
> #10 0xaaae50d7e1dc in qmp_marshal_device_list_properties qemu/qapi/qapi-commands-qdev.c:59
> #11 0xaaae50dc87a0 in do_qmp_dispatch_bh qemu/qapi/qmp-dispatch.c:110
> #12 0xaaae50d931a0 in aio_bh_call qemu/util/async.c:136
>
> Reported-by: Euler Robot <euler.robot@huawei.com>
> Signed-off-by: Gan Qixin <ganqixin@huawei.com>
> ---
> Cc: David Gibson <david@gibson.dropbear.id.au>
> ---
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
thanks
-- PMM
next prev parent reply other threads:[~2021-01-12 16:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-12 11:27 [PATCH v3 0/2] Fix some memleaks caused by timer_new_ns Gan Qixin
2021-01-12 11:27 ` [PATCH v3 1/2] pl031: Use timer_free() in the finalize function to avoid memleaks Gan Qixin
2021-01-12 16:42 ` Peter Maydell
2021-01-12 19:59 ` Laurent Vivier
2021-01-12 11:27 ` [PATCH v3 2/2] misc/mos6522: Use timer_free() in the finalize function to avoid memleak Gan Qixin
2021-01-12 12:17 ` Philippe Mathieu-Daudé
2021-01-12 16:42 ` Peter Maydell [this message]
2021-01-12 20:00 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFEAcA-Wh97xhmyjjJoD9HKiAhHq7SzuPjUoLWg=j4BPtHmWUw@mail.gmail.com' \
--to=peter.maydell@linaro.org \
--cc=david@gibson.dropbear.id.au \
--cc=euler.robot@huawei.com \
--cc=ganqixin@huawei.com \
--cc=kuhn.chenqun@huawei.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=zhang.zhanghailiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.